[v1] HID: google: modify HID device groups of eel

[PATCH] HID: google: modify HID device groups of eel

Posted by xiazhengqiao 4 years, 6 months ago

EEL keyboard belongs to VIVALDI	device.

Signed-off-by: xiazhengqiao <xiazhengqiao@huaqin.corp-partner.google.com>
---
 drivers/hid/hid-google-hammer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hammer.c
index 0403beb3104b..e5acd15f4a55 100644
--- a/drivers/hid/hid-google-hammer.c
+++ b/drivers/hid/hid-google-hammer.c
@@ -585,7 +585,7 @@ static void hammer_remove(struct hid_device *hdev)
 static const struct hid_device_id hammer_devices[] = {
 	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
 		     USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_DON) },
-	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
+	{ HID_DEVICE(BUS_USB, HID_GROUP_VIVALDI,
 		     USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_EEL) },
 	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
 		     USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_HAMMER) },
-- 
2.17.1

Re: [PATCH] HID: google: modify HID device groups of eel

Posted by xiazhengqiao 4 years, 5 months ago

  EEL keyboard belongs to VIVALDI device. I have tested it.

please help to review this.

thanks.

Re: [PATCH] HID: google: modify HID device groups of eel

Posted by Jiri Kosina 4 years, 5 months ago

On Tue, 28 Dec 2021, xiazhengqiao wrote:

> EEL keyboard belongs to VIVALDI	device.
> 
> Signed-off-by: xiazhengqiao <xiazhengqiao@huaqin.corp-partner.google.com>

Could you please provide more verbose changelog? What user-observable 
issue you are fixing here, etc.

Also, unless xiazhengqiao is your proper legal name, could you please 
resubmit with a proper full name as indicated in 
Documentation/process/submitting-patches.rst ?

Thanks!

-- 
Jiri Kosina
SUSE Labs