[PATCH] net: caif: remove redundant assignment to variable expectlen

Colin Ian King posted 1 patch 4 years, 6 months ago
net/caif/cfserl.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] net: caif: remove redundant assignment to variable expectlen
Posted by Colin Ian King 4 years, 6 months ago
Variable expectlen is being assigned a value that is never read, the
assignment occurs before a return statement. The assignment is
redundant and can be removed.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 net/caif/cfserl.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/caif/cfserl.c b/net/caif/cfserl.c
index 40cd57ad0a0f..aee11c74d3c8 100644
--- a/net/caif/cfserl.c
+++ b/net/caif/cfserl.c
@@ -128,7 +128,6 @@ static int cfserl_receive(struct cflayer *l, struct cfpkt *newpkt)
 				if (pkt != NULL)
 					cfpkt_destroy(pkt);
 				layr->incomplete_frm = NULL;
-				expectlen = 0;
 				spin_unlock(&layr->sync);
 				return -EPROTO;
 			}
-- 
2.33.1

Re: [PATCH] net: caif: remove redundant assignment to variable expectlen
Posted by patchwork-bot+netdevbpf@kernel.org 4 years, 6 months ago
Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Tue, 28 Dec 2021 00:45:42 +0000 you wrote:
> Variable expectlen is being assigned a value that is never read, the
> assignment occurs before a return statement. The assignment is
> redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  net/caif/cfserl.c | 1 -
>  1 file changed, 1 deletion(-)

Here is the summary with links:
  - net: caif: remove redundant assignment to variable expectlen
    https://git.kernel.org/netdev/net-next/c/0f1eae8e565e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html