There is no need to initialize ret with 0, as all the early error branches
simply return constant values, and the default path always reaches
ret = kern_path(filename, LOOKUP_FOLLOW, &path), which will reset ret
before the initial value was ever used.

Remove this unneeded initialization and keep the code succinct.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 kernel/trace/trace_uprobe.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index 5921951a0d5c..9da10c5efdce 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -548,7 +548,6 @@ static int __trace_uprobe_create(int argc, const char **argv)
 	bool is_return = false;
 	int i, ret;
 
-	ret = 0;
 	ref_ctr_offset = 0;
 
 	switch (argv[0][0]) {
-- 
2.17.1

Masami, want to ack this?

-- Steve


On Mon, 27 Dec 2021 13:53:08 +0100
Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:

> There is no need to initialize ret with 0, as all the early error branches
> simply return constant values, and the default path always reaches
> ret = kern_path(filename, LOOKUP_FOLLOW, &path), which will reset ret
> before the initial value was ever used.
> 
> Remove this unneeded initialization and keep the code succinct.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
>  kernel/trace/trace_uprobe.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index 5921951a0d5c..9da10c5efdce 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -548,7 +548,6 @@ static int __trace_uprobe_create(int argc, const char **argv)
>  	bool is_return = false;
>  	int i, ret;
>  
> -	ret = 0;
>  	ref_ctr_offset = 0;
>  
>  	switch (argv[0][0]) {

On Wed, 5 Jan 2022 18:57:15 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> Masami, want to ack this?
> 
> -- Steve
> 
> 
> On Mon, 27 Dec 2021 13:53:08 +0100
> Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> 
> > There is no need to initialize ret with 0, as all the early error branches
> > simply return constant values, and the default path always reaches
> > ret = kern_path(filename, LOOKUP_FOLLOW, &path), which will reset ret
> > before the initial value was ever used.
> > 
> > Remove this unneeded initialization and keep the code succinct.

Thanks, this looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Regards,

> > 
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > ---
> >  kernel/trace/trace_uprobe.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> > index 5921951a0d5c..9da10c5efdce 100644
> > --- a/kernel/trace/trace_uprobe.c
> > +++ b/kernel/trace/trace_uprobe.c
> > @@ -548,7 +548,6 @@ static int __trace_uprobe_create(int argc, const char **argv)
> >  	bool is_return = false;
> >  	int i, ret;
> >  
> > -	ret = 0;
> >  	ref_ctr_offset = 0;
> >  
> >  	switch (argv[0][0]) {
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>