[PATCH 00/10] staging: r8188eu: clean up private ioctls

Martin Kaiser posted 10 patches 4 years, 6 months ago
drivers/staging/r8188eu/os_dep/ioctl_linux.c | 141 +------------------
1 file changed, 7 insertions(+), 134 deletions(-)
[PATCH 00/10] staging: r8188eu: clean up private ioctls
Posted by Martin Kaiser 4 years, 6 months ago
Clean up the definitions of private ioctls.
(Maybe it would make more sense to remove them completely?)

Martin Kaiser (10):
  staging: r8188eu: remove unused rtw_private_args entries
  staging: r8188eu: remove the private ioctl "get sensitivity"
  staging: r8188eu: remove the private drvext_hdl ioctl
  staging: r8188eu: remove the private ioctl "wps_prob_req_ie"
  staging: r8188eu: remove private ioctls that return -1
  staging: r8188eu: remove the private ioctl "wps_assoc_req_ie"
  staging: r8188eu: remove the private ioctl "tdls_get"
  staging: r8188eu: remove the private ioctl "tdls"
  staging: r8188eu: remove the private "test" ioctl
  staging: r8188eu: remove unused prototype

 drivers/staging/r8188eu/os_dep/ioctl_linux.c | 141 +------------------
 1 file changed, 7 insertions(+), 134 deletions(-)

-- 
2.30.2

Re: [PATCH 00/10] staging: r8188eu: clean up private ioctls
Posted by Greg Kroah-Hartman 4 years, 6 months ago
On Sun, Dec 26, 2021 at 10:25:25PM +0100, Martin Kaiser wrote:
> Clean up the definitions of private ioctls.
> (Maybe it would make more sense to remove them completely?)

If none of them are really "standard", then yes, they should be removed.

At the very least, the correct macros should be used for the remaining
ones.

I'll go queue this up now, thanks!

greg k-h