kernel/sysctl.c: remove unused variable ten_thousand

[PATCH][next] kernel/sysctl.c: remove unused variable ten_thousand

Posted by Colin Ian King 4 years, 6 months ago

The const variable ten_thousand is not used, it is redundant and can
be removed.

Cleans up clang warning:
kernel/sysctl.c:99:18: warning: unused variable 'ten_thousand' [-Wunused-const-variable]
static const int ten_thousand = 10000;

Fixes: c26da54dc8ca ("printk: move printk sysctl to printk/sysctl.c")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 kernel/sysctl.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 7f07b058b180..ace130de4a17 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -95,9 +95,6 @@
 
 /* Constants used for minimum and  maximum */
 
-#ifdef CONFIG_PRINTK
-static const int ten_thousand = 10000;
-#endif
 #ifdef CONFIG_PERF_EVENTS
 static const int six_hundred_forty_kb = 640 * 1024;
 #endif
-- 
2.33.1

Re: [PATCH][next] kernel/sysctl.c: remove unused variable ten_thousand

Posted by Luis Chamberlain 4 years, 6 months ago

On Tue, Dec 21, 2021 at 06:45:01PM +0000, Colin Ian King wrote:
> The const variable ten_thousand is not used, it is redundant and can
> be removed.
> 
> Cleans up clang warning:
> kernel/sysctl.c:99:18: warning: unused variable 'ten_thousand' [-Wunused-const-variable]
> static const int ten_thousand = 10000;
> 
> Fixes: c26da54dc8ca ("printk: move printk sysctl to printk/sysctl.c")
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Acked-by: Andrew Morton <akpm@linux-foundation.org>

  Luis

Re: [PATCH][next] kernel/sysctl.c: remove unused variable ten_thousand

Posted by Nick Desaulniers 4 years, 6 months ago

On Tue, Dec 21, 2021 at 1:46 PM Luis Chamberlain <mcgrof@kernel.org> wrote:
>
> On Tue, Dec 21, 2021 at 06:45:01PM +0000, Colin Ian King wrote:
> > The const variable ten_thousand is not used, it is redundant and can
> > be removed.
> >
> > Cleans up clang warning:
> > kernel/sysctl.c:99:18: warning: unused variable 'ten_thousand' [-Wunused-const-variable]
> > static const int ten_thousand = 10000;
> >
> > Fixes: c26da54dc8ca ("printk: move printk sysctl to printk/sysctl.c")
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
> Acked-by: Andrew Morton <akpm@linux-foundation.org>

Just double checking; I don't think I've seen someone supply someone
else's Acked by tag in a reply before. Was there some discussion off
thread that I missed? If so, do you mind linking to it?  Was this a
typo, perhaps, and you meant to supply your own Acked by tag? Are
"Luis Chamberlain" and "Andrew Morton" aliases? :^P

-- 
Thanks,
~Nick Desaulniers