[PATCH] mtd: rawnand: omap_elm: remove redundant variable 'errors'

Colin Ian King posted 1 patch 4 years, 6 months ago
drivers/mtd/nand/raw/omap_elm.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
[PATCH] mtd: rawnand: omap_elm: remove redundant variable 'errors'
Posted by Colin Ian King 4 years, 6 months ago
The variable 'errors' is being used to sum the number of errors
but it is never used afterwards. This can be considered a
redundant set of operations and can be removed.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/mtd/nand/raw/omap_elm.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mtd/nand/raw/omap_elm.c b/drivers/mtd/nand/raw/omap_elm.c
index 8bab753211e9..0b6aeb269c33 100644
--- a/drivers/mtd/nand/raw/omap_elm.c
+++ b/drivers/mtd/nand/raw/omap_elm.c
@@ -282,7 +282,7 @@ static void elm_start_processing(struct elm_info *info,
 static void elm_error_correction(struct elm_info *info,
 		struct elm_errorvec *err_vec)
 {
-	int i, j, errors = 0;
+	int i, j;
 	int offset;
 	u32 reg_val;
 
@@ -312,8 +312,6 @@ static void elm_error_correction(struct elm_info *info,
 					/* Update error location register */
 					offset += 4;
 				}
-
-				errors += err_vec[i].error_count;
 			} else {
 				err_vec[i].error_uncorrectable = true;
 			}
-- 
2.33.1

Re: [PATCH] mtd: rawnand: omap_elm: remove redundant variable 'errors'
Posted by Miquel Raynal 4 years, 5 months ago
On Tue, 2021-12-21 at 18:13:40 UTC, Colin Ian King wrote:
> The variable 'errors' is being used to sum the number of errors
> but it is never used afterwards. This can be considered a
> redundant set of operations and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel