[v2] media: platform: Add brask to the match table

[PATCH v2] media: platform: Add brask to the match table

Posted by Zhuohao Lee 4 years, 6 months ago

The Google Brask device uses the same approach as the Google Fizz
which enables the HDMI CEC via the cros-ec-cec driver.

Signed-off-by: Zhuohao Lee <zhuohao@chromium.org>
---
 drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
index 2d95e16cd248..8c8d8fc5e63e 100644
--- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
+++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
@@ -215,6 +215,8 @@ struct cec_dmi_match {
 static const struct cec_dmi_match cec_dmi_match_table[] = {
 	/* Google Fizz */
 	{ "Google", "Fizz", "0000:00:02.0", "Port B" },
+	/* Google Brask */
+	{ "Google", "Brask", "0000:00:02.0", "Port B" },
 };
 
 static struct device *cros_ec_cec_find_hdmi_dev(struct device *dev,
-- 
2.34.1.307.g9b7440fafd-goog

Re: [PATCH v2] media: platform: Add brask to the match table

Posted by Guenter Roeck 4 years, 6 months ago

On Tue, Dec 21, 2021 at 1:53 AM Zhuohao Lee <zhuohao@chromium.org> wrote:
>
> The Google Brask device uses the same approach as the Google Fizz
> which enables the HDMI CEC via the cros-ec-cec driver.
>
> Signed-off-by: Zhuohao Lee <zhuohao@chromium.org>

Reviewed-by: Guenter Roeck <groeck@chromium.org>

> ---

Side note: Change log goes here. Don't expect maintainers to know what
changed in v2.

>  drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> index 2d95e16cd248..8c8d8fc5e63e 100644
> --- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> +++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> @@ -215,6 +215,8 @@ struct cec_dmi_match {
>  static const struct cec_dmi_match cec_dmi_match_table[] = {
>         /* Google Fizz */
>         { "Google", "Fizz", "0000:00:02.0", "Port B" },
> +       /* Google Brask */
> +       { "Google", "Brask", "0000:00:02.0", "Port B" },
>  };
>
>  static struct device *cros_ec_cec_find_hdmi_dev(struct device *dev,
> --
> 2.34.1.307.g9b7440fafd-goog
>

Re: [PATCH v2] media: platform: Add brask to the match table

Posted by Hans Verkuil 4 years, 5 months ago

On 21/12/2021 10:53, Zhuohao Lee wrote:
> The Google Brask device uses the same approach as the Google Fizz
> which enables the HDMI CEC via the cros-ec-cec driver.

For future reference, please add the driver name in the subject as well.

A patch with just "media: platform:" as prefix suggests a patch that
touches on many drivers in media/platform.

I've manually updated the prefix, so no need for you to do anything.

Regards,

	Hans

> 
> Signed-off-by: Zhuohao Lee <zhuohao@chromium.org>
> ---
>  drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> index 2d95e16cd248..8c8d8fc5e63e 100644
> --- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> +++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> @@ -215,6 +215,8 @@ struct cec_dmi_match {
>  static const struct cec_dmi_match cec_dmi_match_table[] = {
>  	/* Google Fizz */
>  	{ "Google", "Fizz", "0000:00:02.0", "Port B" },
> +	/* Google Brask */
> +	{ "Google", "Brask", "0000:00:02.0", "Port B" },
>  };
>  
>  static struct device *cros_ec_cec_find_hdmi_dev(struct device *dev,