random: fix some data races

[PATCH v2 0/2] random: fix some data races

Posted by Eric Biggers 4 years, 6 months ago

This series fixes some data races in random.c.

Changed v1 => v2:
   - Remove unneeded 'inline' keywords
   - Use READ_ONCE() instead of smp_load_acquire()
   - Updated commit message
   - Added patch to fix data race on crng init time

Eric Biggers (2):
  random: fix data race on crng_node_pool
  random: fix data race on crng init time

 drivers/char/random.c | 61 +++++++++++++++++++++++--------------------
 1 file changed, 33 insertions(+), 28 deletions(-)

-- 
2.34.1

Re: [PATCH v2 0/2] random: fix some data races

Posted by Paul E. McKenney 4 years, 6 months ago

On Mon, Dec 20, 2021 at 04:41:55PM -0600, Eric Biggers wrote:
> This series fixes some data races in random.c.
> 
> Changed v1 => v2:
>    - Remove unneeded 'inline' keywords
>    - Use READ_ONCE() instead of smp_load_acquire()
>    - Updated commit message
>    - Added patch to fix data race on crng init time
> 
> Eric Biggers (2):
>   random: fix data race on crng_node_pool
>   random: fix data race on crng init time

From a memory-ordering viewpoint:

Acked-by: Paul E. McKenney <paulmck@kernel.org>

>  drivers/char/random.c | 61 +++++++++++++++++++++++--------------------
>  1 file changed, 33 insertions(+), 28 deletions(-)
> 
> -- 
> 2.34.1
>

Re: [PATCH v2 0/2] random: fix some data races

Posted by Jason A. Donenfeld 4 years, 6 months ago

All applied to crng/random.git. Thanks for the series.

Jason