mfd: ntxec: Change return type of ntxec_reg8 from __be16 to u16

[PATCH] mfd: ntxec: Change return type of ntxec_reg8 from __be16 to u16

Posted by Jonathan Neuschäfer 4 years, 6 months ago

Register values in NTXEC are big-endian on the I2C bus, but the regmap
subsystem handles the conversion between CPU-endian and big-endian data
internally. ntxec_reg8 should thus return u16, not __be16.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
 include/linux/mfd/ntxec.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mfd/ntxec.h b/include/linux/mfd/ntxec.h
index 26ab3b8eb612f..cc6f07bfa2b34 100644
--- a/include/linux/mfd/ntxec.h
+++ b/include/linux/mfd/ntxec.h
@@ -26,7 +26,7 @@ struct ntxec {
  * This convenience function converts an 8-bit value to 16-bit for use in the
  * second kind of register.
  */
-static inline __be16 ntxec_reg8(u8 value)
+static inline u16 ntxec_reg8(u8 value)
 {
 	return value << 8;
 }
--
2.30.2

Re: [PATCH] mfd: ntxec: Change return type of ntxec_reg8 from __be16 to u16

Posted by Lee Jones 4 years, 6 months ago

On Sat, 18 Dec 2021, Jonathan Neuschäfer wrote:

> Register values in NTXEC are big-endian on the I2C bus, but the regmap
> subsystem handles the conversion between CPU-endian and big-endian data
> internally. ntxec_reg8 should thus return u16, not __be16.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
>  include/linux/mfd/ntxec.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog