RDMA/rxe: fix a typo in opcode name

[PATCH] RDMA/rxe: fix a typo in opcode name

Posted by Chengguang Xu 4 years, 6 months ago

There is a redundant ']' in the name of opcode IB_OPCODE_RC_SEND_MIDDLE,
so just fix it.

Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
 drivers/infiniband/sw/rxe/rxe_opcode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/sw/rxe/rxe_opcode.c b/drivers/infiniband/sw/rxe/rxe_opcode.c
index 3ef5a10a6efd..47ebaac8f475 100644
--- a/drivers/infiniband/sw/rxe/rxe_opcode.c
+++ b/drivers/infiniband/sw/rxe/rxe_opcode.c
@@ -117,7 +117,7 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
 		}
 	},
 	[IB_OPCODE_RC_SEND_MIDDLE]		= {
-		.name	= "IB_OPCODE_RC_SEND_MIDDLE]",
+		.name	= "IB_OPCODE_RC_SEND_MIDDLE",
 		.mask	= RXE_PAYLOAD_MASK | RXE_REQ_MASK | RXE_SEND_MASK
 				| RXE_MIDDLE_MASK,
 		.length = RXE_BTH_BYTES,
-- 
2.27.0

Re: [PATCH] RDMA/rxe: fix a typo in opcode name

Posted by Zhu Yanjun 4 years, 6 months ago

On Sat, Dec 18, 2021 at 7:23 PM Chengguang Xu <cgxu519@mykernel.net> wrote:
>
> There is a redundant ']' in the name of opcode IB_OPCODE_RC_SEND_MIDDLE,
> so just fix it.
>
> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>

Acked-by: Zhu Yanjun <zyjzyj2000@gmail.com>

Zhu Yanjun

> ---
>  drivers/infiniband/sw/rxe/rxe_opcode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_opcode.c b/drivers/infiniband/sw/rxe/rxe_opcode.c
> index 3ef5a10a6efd..47ebaac8f475 100644
> --- a/drivers/infiniband/sw/rxe/rxe_opcode.c
> +++ b/drivers/infiniband/sw/rxe/rxe_opcode.c
> @@ -117,7 +117,7 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
>                 }
>         },
>         [IB_OPCODE_RC_SEND_MIDDLE]              = {
> -               .name   = "IB_OPCODE_RC_SEND_MIDDLE]",
> +               .name   = "IB_OPCODE_RC_SEND_MIDDLE",
>                 .mask   = RXE_PAYLOAD_MASK | RXE_REQ_MASK | RXE_SEND_MASK
>                                 | RXE_MIDDLE_MASK,
>                 .length = RXE_BTH_BYTES,
> --
> 2.27.0
>
>

Re: [PATCH] RDMA/rxe: fix a typo in opcode name

Posted by Bob Pearson 4 years, 6 months ago

On 12/18/21 05:23, Chengguang Xu wrote:
> There is a redundant ']' in the name of opcode IB_OPCODE_RC_SEND_MIDDLE,
> so just fix it.
> 
> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
> ---
>  drivers/infiniband/sw/rxe/rxe_opcode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/sw/rxe/rxe_opcode.c b/drivers/infiniband/sw/rxe/rxe_opcode.c
> index 3ef5a10a6efd..47ebaac8f475 100644
> --- a/drivers/infiniband/sw/rxe/rxe_opcode.c
> +++ b/drivers/infiniband/sw/rxe/rxe_opcode.c
> @@ -117,7 +117,7 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
>  		}
>  	},
>  	[IB_OPCODE_RC_SEND_MIDDLE]		= {
> -		.name	= "IB_OPCODE_RC_SEND_MIDDLE]",
> +		.name	= "IB_OPCODE_RC_SEND_MIDDLE",
>  		.mask	= RXE_PAYLOAD_MASK | RXE_REQ_MASK | RXE_SEND_MASK
>  				| RXE_MIDDLE_MASK,
>  		.length = RXE_BTH_BYTES,
> 

Looks good

Reviewed-by: Bob Pearson <rpearsonhpe@gmail.com>

Re: [PATCH] RDMA/rxe: fix a typo in opcode name

Posted by Jason Gunthorpe 4 years, 5 months ago

On Sat, Dec 18, 2021 at 07:23:20PM +0800, Chengguang Xu wrote:
> There is a redundant ']' in the name of opcode IB_OPCODE_RC_SEND_MIDDLE,
> so just fix it.
> 
> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
> Acked-by: Zhu Yanjun <zyjzyj2000@gmail.com>
> Reviewed-by: Bob Pearson <rpearsonhpe@gmail.com>
> ---
>  drivers/infiniband/sw/rxe/rxe_opcode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-next, thanks

I added a fixes line

Jason