[PATCH] net: vertexcom: Remove unneeded semicolon

cgel.zte@gmail.com posted 1 patch 4 years, 6 months ago
drivers/net/ethernet/vertexcom/mse102x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] net: vertexcom: Remove unneeded semicolon
Posted by cgel.zte@gmail.com 4 years, 6 months ago
From: Changcheng Deng <deng.changcheng@zte.com.cn>

Fix the following coccicheck review:
./drivers/net/ethernet/vertexcom/mse102x.c: 414: 2-3: Unneeded semicolon

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
 drivers/net/ethernet/vertexcom/mse102x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/vertexcom/mse102x.c b/drivers/net/ethernet/vertexcom/mse102x.c
index a3c2426e5597..89a31783fbb4 100644
--- a/drivers/net/ethernet/vertexcom/mse102x.c
+++ b/drivers/net/ethernet/vertexcom/mse102x.c
@@ -411,7 +411,7 @@ static int mse102x_tx_pkt_spi(struct mse102x_net *mse, struct sk_buff *txb,
 		} else {
 			msleep(20);
 		}
-	};
+	}
 
 	ret = mse102x_tx_frame_spi(mse, txb, pad);
 	if (ret)
-- 
2.25.1

Re: [PATCH] net: vertexcom: Remove unneeded semicolon
Posted by Stefan Wahren 4 years, 6 months ago
Am 17.12.21 um 09:48 schrieb cgel.zte@gmail.com:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>
> Fix the following coccicheck review:
> ./drivers/net/ethernet/vertexcom/mse102x.c: 414: 2-3: Unneeded semicolon
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
Reviewed-by: Stefan Wahren <stefan.wahren@i2se.com>
Re: [PATCH] net: vertexcom: Remove unneeded semicolon
Posted by Jakub Kicinski 4 years, 6 months ago
On Fri, 17 Dec 2021 08:48:27 +0000 cgel.zte@gmail.com wrote:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
> 
> Fix the following coccicheck review:
> ./drivers/net/ethernet/vertexcom/mse102x.c: 414: 2-3: Unneeded semicolon

The Alibaba bot has beaten you to the punch, see commit 431b9b4d9789
("net: vertexcom: remove unneeded semicolon") in net-next.

Here we thought that "robot wars" will be like Terminator, what we got 
instead is false scarcity of concert tickets and auto-generated patches
which often don't build :(