net/9p/trans_virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
start my first kernel patch commit
Signed-off-by: zhuxinran <zhuran@mail.ustc.edu.cn>
---
net/9p/trans_virtio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c
index bd5a89c4960d..f7dc561ca516 100644
--- a/net/9p/trans_virtio.c
+++ b/net/9p/trans_virtio.c
@@ -648,7 +648,7 @@ static int p9_virtio_probe(struct virtio_device *vdev)
* @args: args passed from sys_mount() for per-transport options (unused)
*
* This sets up a transport channel for 9p communication. Right now
- * we only match the first available channel, but eventually we couldlook up
+ * we only match the first available channel, but eventually we could look up
* alternate channels by matching devname versus a virtio_config entry.
* We use a simple reference count mechanism to ensure that only a single
* mount has a channel open at a time.
--
2.33.1
On Thu, Dec 16, 2021 at 11:09 AM zhuxinran <zhuran@mail.ustc.edu.cn> wrote: > > start my first kernel patch commit > Patch looks good but this is not a good change log. It should be something like "Fix typo in the comment for p9_virtio_create()" Thanks > Signed-off-by: zhuxinran <zhuran@mail.ustc.edu.cn> > --- > net/9p/trans_virtio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c > index bd5a89c4960d..f7dc561ca516 100644 > --- a/net/9p/trans_virtio.c > +++ b/net/9p/trans_virtio.c > @@ -648,7 +648,7 @@ static int p9_virtio_probe(struct virtio_device *vdev) > * @args: args passed from sys_mount() for per-transport options (unused) > * > * This sets up a transport channel for 9p communication. Right now > - * we only match the first available channel, but eventually we couldlook up > + * we only match the first available channel, but eventually we could look up > * alternate channels by matching devname versus a virtio_config entry. > * We use a simple reference count mechanism to ensure that only a single > * mount has a channel open at a time. > -- > 2.33.1 > >
Thanks for the patch. A few comments below: zhuxinran wrote on Thu, Dec 16, 2021 at 11:08:36AM +0800: > Subject: virtio: fix spelling error "virtio" is much more than this. Have a look at previous commit messages for this file, something like '9p/trans_virtio' would make a better component name. (`git log net/9p/trans_virtio.c` to get git history for a single file) > start my first kernel patch commit This is not particularly useful for someone reading the git log, I'd just remove this line. I can do both changes on my end, but since you're learning it can also be a good time to also see how to send a v2 (setting subject as [PATCH v2], sending patch with in-reply-to) I don't really mind either way, please let me know if you won't resend. -- Dominique
© 2016 - 2026 Red Hat, Inc.