dsa: mv88e6xxx: fix debug print for SPEED_UNFORCED

[PATCH] dsa: mv88e6xxx: fix debug print for SPEED_UNFORCED

Posted by Andrey Eremeev 4 years, 6 months ago

Debug print uses invalid check to detect if speed is unforced:
(speed != SPEED_UNFORCED) should be used instead of (!speed).

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Andrey Eremeev <Axtone4all@yandex.ru>
Fixes: 96a2b40c7bd3 ("net: dsa: mv88e6xxx: add port's MAC speed setter")
---
 drivers/net/dsa/mv88e6xxx/port.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/dsa/mv88e6xxx/port.c b/drivers/net/dsa/mv88e6xxx/port.c
index d9817b20ea64..ab41619a809b 100644
--- a/drivers/net/dsa/mv88e6xxx/port.c
+++ b/drivers/net/dsa/mv88e6xxx/port.c
@@ -283,7 +283,7 @@ static int mv88e6xxx_port_set_speed_duplex(struct mv88e6xxx_chip *chip,
 	if (err)
 		return err;

-	if (speed)
+	if (speed != SPEED_UNFORCED)
 		dev_dbg(chip->dev, "p%d: Speed set to %d Mbps\n", port, speed);
 	else
 		dev_dbg(chip->dev, "p%d: Speed unforced\n", port);
@@ -516,7 +516,7 @@ int mv88e6393x_port_set_speed_duplex(struct mv88e6xxx_chip *chip, int port,
 	if (err)
 		return err;

-	if (speed)
+	if (speed != SPEED_UNFORCED)
 		dev_dbg(chip->dev, "p%d: Speed set to %d Mbps\n", port, speed);
 	else
 		dev_dbg(chip->dev, "p%d: Speed unforced\n", port);
--
2.30.1 (Apple Git-130)

Re: [PATCH] dsa: mv88e6xxx: fix debug print for SPEED_UNFORCED

Posted by Andrew Lunn 4 years, 6 months ago

On Wed, Dec 15, 2021 at 08:30:32PM +0300, Andrey Eremeev wrote:
> Debug print uses invalid check to detect if speed is unforced:
> (speed != SPEED_UNFORCED) should be used instead of (!speed).
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Andrey Eremeev <Axtone4all@yandex.ru>
> Fixes: 96a2b40c7bd3 ("net: dsa: mv88e6xxx: add port's MAC speed setter")

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH] dsa: mv88e6xxx: fix debug print for SPEED_UNFORCED

Posted by patchwork-bot+netdevbpf@kernel.org 4 years, 6 months ago

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Wed, 15 Dec 2021 20:30:32 +0300 you wrote:
> Debug print uses invalid check to detect if speed is unforced:
> (speed != SPEED_UNFORCED) should be used instead of (!speed).
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Andrey Eremeev <Axtone4all@yandex.ru>
> Fixes: 96a2b40c7bd3 ("net: dsa: mv88e6xxx: add port's MAC speed setter")
> 
> [...]

Here is the summary with links:
  - dsa: mv88e6xxx: fix debug print for SPEED_UNFORCED
    https://git.kernel.org/netdev/net/c/e08cdf63049b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html