sound/soc/mediatek/mt8192/mt8192-afe-pcm.c | 2 -- 1 file changed, 2 deletions(-)
The unnecessary conditional inclusion caused the following warning.
>> sound/soc/mediatek/mt8192/mt8192-afe-pcm.c:2368:32: warning: unused
>> variable 'mt8192_afe_pm_ops' [-Wunused-const-variable]
static const struct dev_pm_ops mt8192_afe_pm_ops = {
Because runtime_pm already handles the case without CONFIG_PM, we
can remove CONFIG_PM condition.
Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
Reported-by: kernel test robot <lkp@intel.com>
---
sound/soc/mediatek/mt8192/mt8192-afe-pcm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/mediatek/mt8192/mt8192-afe-pcm.c b/sound/soc/mediatek/mt8192/mt8192-afe-pcm.c
index 31c280339c50..e1e4ca931551 100644
--- a/sound/soc/mediatek/mt8192/mt8192-afe-pcm.c
+++ b/sound/soc/mediatek/mt8192/mt8192-afe-pcm.c
@@ -2381,9 +2381,7 @@ static struct platform_driver mt8192_afe_pcm_driver = {
.driver = {
.name = "mt8192-audio",
.of_match_table = mt8192_afe_pcm_dt_match,
-#ifdef CONFIG_PM
.pm = &mt8192_afe_pm_ops,
-#endif
},
.probe = mt8192_afe_pcm_dev_probe,
.remove = mt8192_afe_pcm_dev_remove,
--
2.25.1
On Tue, Nov 23, 2021 at 12:48 AM Jiaxin Yu <jiaxin.yu@mediatek.com> wrote: > Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com> > Reported-by: kernel test robot <lkp@intel.com> Acked-by: Tzung-Bi Shih <tzungbi@google.com> Could you also submit another series for the cleanup? At least for sound/soc/mediatek/: $ rg --files-with-matches CONFIG_PM sound/soc/mediatek/ sound/soc/mediatek/mt8173/mt8173-rt5650-rt5676.c sound/soc/mediatek/mt8173/mt8173-rt5650.c sound/soc/mediatek/mt8173/mt8173-max98090.c sound/soc/mediatek/mt8173/mt8173-rt5650-rt5514.c sound/soc/mediatek/mt6797/mt6797-afe-pcm.c sound/soc/mediatek/mt2701/mt2701-afe-pcm.c sound/soc/mediatek/mt8192/mt8192-afe-pcm.c sound/soc/mediatek/mt8183/mt8183-afe-pcm.c
On Tue, 2021-11-23 at 11:12 +0800, Tzung-Bi Shih wrote: > On Tue, Nov 23, 2021 at 12:48 AM Jiaxin Yu <jiaxin.yu@mediatek.com> > wrote: > > Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com> > > Reported-by: kernel test robot <lkp@intel.com> > > Acked-by: Tzung-Bi Shih <tzungbi@google.com> > > Could you also submit another series for the cleanup? > > At least for sound/soc/mediatek/: > $ rg --files-with-matches CONFIG_PM sound/soc/mediatek/ > sound/soc/mediatek/mt8173/mt8173-rt5650-rt5676.c > sound/soc/mediatek/mt8173/mt8173-rt5650.c > sound/soc/mediatek/mt8173/mt8173-max98090.c > sound/soc/mediatek/mt8173/mt8173-rt5650-rt5514.c > sound/soc/mediatek/mt6797/mt6797-afe-pcm.c > sound/soc/mediatek/mt2701/mt2701-afe-pcm.c > sound/soc/mediatek/mt8192/mt8192-afe-pcm.c > sound/soc/mediatek/mt8183/mt8183-afe-pcm.c Hi Tzung-Bi, Ok, I will remove them from sound/soc/mediatek folder in PATCH v2. Thank you for reminding.
© 2016 - 2024 Red Hat, Inc.