drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
The print function dev_err() is redundant because
platform_get_irq() already prints an error.
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
index af994b9913a6..f332beb06d51 100644
--- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
@@ -1361,10 +1361,8 @@ static int mtk_jpeg_probe(struct platform_device *pdev)
}
jpeg_irq = platform_get_irq(pdev, 0);
- if (jpeg_irq < 0) {
- dev_err(&pdev->dev, "Failed to get jpeg_irq %d.\n", jpeg_irq);
+ if (jpeg_irq < 0)
return jpeg_irq;
- }
ret = devm_request_irq(&pdev->dev, jpeg_irq,
jpeg->variant->irq_handler, 0, pdev->name, jpeg);
--
2.25.1
Quoting Xu Wang (2021-11-16 01:47:26) > The print function dev_err() is redundant because > platform_get_irq() already prints an error. This one was also reporting errors in the case of -EPROBE_DEFER, which will now go away, so this looks like a valid change to me. Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > Signed-off-by: Xu Wang <vulab@iscas.ac.cn> > --- > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > index af994b9913a6..f332beb06d51 100644 > --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > @@ -1361,10 +1361,8 @@ static int mtk_jpeg_probe(struct platform_device *pdev) > } > > jpeg_irq = platform_get_irq(pdev, 0); > - if (jpeg_irq < 0) { > - dev_err(&pdev->dev, "Failed to get jpeg_irq %d.\n", jpeg_irq); > + if (jpeg_irq < 0) > return jpeg_irq; > - } > > ret = devm_request_irq(&pdev->dev, jpeg_irq, > jpeg->variant->irq_handler, 0, pdev->name, jpeg); > -- > 2.25.1 >
© 2016 - 2024 Red Hat, Inc.