power: reset: POWER_RESET_TORADEX_EC should depend on ARCH_MXC

[PATCH] power: reset: POWER_RESET_TORADEX_EC should depend on ARCH_MXC

Posted by Geert Uytterhoeven 7 months, 1 week ago

The Toradex Embedded Controller is currently only present on Toradex
SMARC iMX8MP and iMX95 SoMs.  Hence add a dependency on ARCH_MXC, to
prevent asking the user about this driver when configuring a kernel
without NXP i.MX SoC family support.

Fixes: 18672fe12367ed44 ("power: reset: add Toradex Embedded Controller")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/power/reset/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
index 5ce402ff71964f59..1a17c5192818de1e 100644
--- a/drivers/power/reset/Kconfig
+++ b/drivers/power/reset/Kconfig
@@ -218,6 +218,7 @@ config POWER_RESET_ST
 
 config POWER_RESET_TORADEX_EC
 	tristate "Toradex Embedded Controller power-off and reset driver"
+	depends on ARCH_MXC || COMPILE_TEST
 	depends on I2C
 	select REGMAP_I2C
 	help
-- 
2.43.0

Re: [PATCH] power: reset: POWER_RESET_TORADEX_EC should depend on ARCH_MXC

Posted by Sebastian Reichel 5 months, 3 weeks ago

On Tue, 06 May 2025 15:01:27 +0200, Geert Uytterhoeven wrote:
> The Toradex Embedded Controller is currently only present on Toradex
> SMARC iMX8MP and iMX95 SoMs.  Hence add a dependency on ARCH_MXC, to
> prevent asking the user about this driver when configuring a kernel
> without NXP i.MX SoC family support.
> 
> 

Applied, thanks!

[1/1] power: reset: POWER_RESET_TORADEX_EC should depend on ARCH_MXC
      commit: 22e4d29f081df8a10f1c062d3d952bb876eb9bdc

Best regards,
-- 
Sebastian Reichel <sebastian.reichel@collabora.com>

Re: [PATCH] power: reset: POWER_RESET_TORADEX_EC should depend on ARCH_MXC

Posted by Emanuele Ghidoli 7 months, 1 week ago

On 06/05/2025 15:01, Geert Uytterhoeven wrote:
> The Toradex Embedded Controller is currently only present on Toradex
> SMARC iMX8MP and iMX95 SoMs.  Hence add a dependency on ARCH_MXC, to
> prevent asking the user about this driver when configuring a kernel
> without NXP i.MX SoC family support.
> 
> Fixes: 18672fe12367ed44 ("power: reset: add Toradex Embedded Controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/power/reset/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> index 5ce402ff71964f59..1a17c5192818de1e 100644
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
> @@ -218,6 +218,7 @@ config POWER_RESET_ST
>  
>  config POWER_RESET_TORADEX_EC
>  	tristate "Toradex Embedded Controller power-off and reset driver"
> +	depends on ARCH_MXC || COMPILE_TEST
>  	depends on I2C
>  	select REGMAP_I2C
>  	help

The default is 'N', and the EC is just an I2C device, unrelated to ARCH_MXC.
Is it really annoying if the user is asked about this driver during
configuration? Or is it just normal?
Wouldn't there be a better way to handle this?