[PATCH net] bcmasp: BCMASP should depend on ARCH_BRCMSTB

Geert Uytterhoeven posted 1 patch 2 years, 6 months ago
drivers/net/ethernet/broadcom/Kconfig | 1 +
1 file changed, 1 insertion(+)
[PATCH net] bcmasp: BCMASP should depend on ARCH_BRCMSTB
Posted by Geert Uytterhoeven 2 years, 6 months ago
The Broadcom ASP 2.0 Ethernet controller is only present on Broadcom STB
SoCs.  Hence add a dependency on ARCH_BRCMSTB, to prevent asking the
user about this driver when configuring a kernel without Broadcom
ARM-based set-top box chipset support.

Fixes: 490cb412007de593 ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/net/ethernet/broadcom/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
index d4166141145d631c..75ca3ddda1f5e09f 100644
--- a/drivers/net/ethernet/broadcom/Kconfig
+++ b/drivers/net/ethernet/broadcom/Kconfig
@@ -257,6 +257,7 @@ config BNXT_HWMON
 
 config BCMASP
 	tristate "Broadcom ASP 2.0 Ethernet support"
+	depends on ARCH_BRCMSTB || COMPILE_TEST
 	default ARCH_BRCMSTB
 	depends on OF
 	select MII
-- 
2.34.1
Re: [PATCH net] bcmasp: BCMASP should depend on ARCH_BRCMSTB
Posted by patchwork-bot+netdevbpf@kernel.org 2 years, 6 months ago
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 25 Jul 2023 17:46:37 +0200 you wrote:
> The Broadcom ASP 2.0 Ethernet controller is only present on Broadcom STB
> SoCs.  Hence add a dependency on ARCH_BRCMSTB, to prevent asking the
> user about this driver when configuring a kernel without Broadcom
> ARM-based set-top box chipset support.
> 
> Fixes: 490cb412007de593 ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> [...]

Here is the summary with links:
  - [net] bcmasp: BCMASP should depend on ARCH_BRCMSTB
    https://git.kernel.org/netdev/net-next/c/73365fe44aa5

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net] bcmasp: BCMASP should depend on ARCH_BRCMSTB
Posted by Justin Chen 2 years, 6 months ago

On 7/25/23 8:46 AM, Geert Uytterhoeven wrote:
> The Broadcom ASP 2.0 Ethernet controller is only present on Broadcom STB
> SoCs.  Hence add a dependency on ARCH_BRCMSTB, to prevent asking the
> user about this driver when configuring a kernel without Broadcom
> ARM-based set-top box chipset support.
> 
> Fixes: 490cb412007de593 ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Justin Chen <justin.chen@broadcom.com>

> ---
>   drivers/net/ethernet/broadcom/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
> index d4166141145d631c..75ca3ddda1f5e09f 100644
> --- a/drivers/net/ethernet/broadcom/Kconfig
> +++ b/drivers/net/ethernet/broadcom/Kconfig
> @@ -257,6 +257,7 @@ config BNXT_HWMON
>   
>   config BCMASP
>   	tristate "Broadcom ASP 2.0 Ethernet support"
> +	depends on ARCH_BRCMSTB || COMPILE_TEST
>   	default ARCH_BRCMSTB
>   	depends on OF
>   	select MII
Re: [PATCH net] bcmasp: BCMASP should depend on ARCH_BRCMSTB
Posted by Florian Fainelli 2 years, 6 months ago

On 7/25/2023 8:46 AM, Geert Uytterhoeven wrote:
> The Broadcom ASP 2.0 Ethernet controller is only present on Broadcom STB
> SoCs.  Hence add a dependency on ARCH_BRCMSTB, to prevent asking the
> user about this driver when configuring a kernel without Broadcom
> ARM-based set-top box chipset support.
> 
> Fixes: 490cb412007de593 ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian
Re: [PATCH net] bcmasp: BCMASP should depend on ARCH_BRCMSTB
Posted by Simon Horman 2 years, 6 months ago
On Tue, Jul 25, 2023 at 05:46:37PM +0200, Geert Uytterhoeven wrote:
> The Broadcom ASP 2.0 Ethernet controller is only present on Broadcom STB
> SoCs.  Hence add a dependency on ARCH_BRCMSTB, to prevent asking the
> user about this driver when configuring a kernel without Broadcom
> ARM-based set-top box chipset support.
> 
> Fixes: 490cb412007de593 ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Simon Horman <simon.horman@corigine.com>