[PATCH v8] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c

Ashwin Gundarapu posted 1 patch 1 month ago
There is a newer version of this series
drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v8] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c
Posted by Ashwin Gundarapu 1 month ago

From c981cdc1149e5ae7e5163f80be1631fc11c4b14d Mon Sep 17 00:00:00 2001
From: Ashwin Gundarapu <linuxuser509@zohomail.in>
Date: Tue, 12 May 2026 17:38:31 +0530
Subject: [PATCH] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c

Remove braces around single statement blocks.

Found by checkpatch.pl --strict

Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
---
v8: Fixed double blank lines. One blank line only between statements.
v7: Added version changelog below the --- line as requested by Greg KH.
---
 drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index c14b8dbd478b..3d88a3a185d5 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -483,10 +483,10 @@ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid_ex *t
 			break;
 		}
 
+
 		if (rtw_roam_flags(adapter))
 			/* TODO: don't select network in the same ess as oldest if it's new enough*/
 
-
 		if (!oldest || time_after(oldest->last_scanned, pnetwork->last_scanned))
 			oldest = pnetwork;
 
-- 
2.43.0
Re: [PATCH v8] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c
Posted by gregkh 1 month ago
On Tue, May 12, 2026 at 05:41:42PM +0530, Ashwin Gundarapu wrote:
> 
> >From c981cdc1149e5ae7e5163f80be1631fc11c4b14d Mon Sep 17 00:00:00 2001
> From: Ashwin Gundarapu <linuxuser509@zohomail.in>
> Date: Tue, 12 May 2026 17:38:31 +0530
> Subject: [PATCH] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c

Why is this in the body?

> 
> Remove braces around single statement blocks.
> 
> Found by checkpatch.pl --strict
> 
> Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
> ---
> v8: Fixed double blank lines. One blank line only between statements.
> v7: Added version changelog below the --- line as requested by Greg KH.
> ---

What about v1 - v6?

>  drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> index c14b8dbd478b..3d88a3a185d5 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> @@ -483,10 +483,10 @@ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid_ex *t
>  			break;
>  		}
>  
> +
>  		if (rtw_roam_flags(adapter))
>  			/* TODO: don't select network in the same ess as oldest if it's new enough*/
>  
> -

This is not what you describe above at all :(