1. Patchew
  2. linux
  3. [PATCHv3 0/6] make vendor specific subdirectory inclusion conditional
  4. View patch

[PATCH 6/6] iommu: make inclusion of iommufd directory conditional

Rolf Eike Beer posted 6 patches 7 months, 1 week ago
Only 5 patches received!
[PATCH 6/6] iommu: make inclusion of iommufd directory conditional
Posted by Rolf Eike Beer 7 months, 1 week ago 
Nothing in there is active if CONFIG_IOMMUFD is not enabled, so the whole
directory can depend on that switch as well.

Fixes: 2ff4bed7fee7 ("iommufd: File descriptor, context, kconfig and makefiles")
Signed-off-by: Rolf Eike Beer <eb@emlix.com>
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
---
 drivers/iommu/Makefile         | 3 ++-
 drivers/iommu/iommufd/Makefile | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/iommu/Makefile b/drivers/iommu/Makefile
index 355294fa9033f..d0a42da2dfa5b 100644
--- a/drivers/iommu/Makefile
+++ b/drivers/iommu/Makefile
@@ -1,8 +1,9 @@
 # SPDX-License-Identifier: GPL-2.0
-obj-y += arm/ iommufd/
+obj-y += arm/
 obj-$(CONFIG_AMD_IOMMU) += amd/
 obj-$(CONFIG_INTEL_IOMMU) += intel/
 obj-$(CONFIG_RISCV_IOMMU) += riscv/
+obj-$(CONFIG_IOMMUFD) += iommufd/
 obj-$(CONFIG_IOMMU_API) += iommu.o
 obj-$(CONFIG_IOMMU_SUPPORT) += iommu-pages.o
 obj-$(CONFIG_IOMMU_API) += iommu-traces.o
diff --git a/drivers/iommu/iommufd/Makefile b/drivers/iommu/iommufd/Makefile
index 71d692c9a8f49..21fa1775eae3f 100644
--- a/drivers/iommu/iommufd/Makefile
+++ b/drivers/iommu/iommufd/Makefile
@@ -12,7 +12,7 @@ iommufd-y := \
 
 iommufd-$(CONFIG_IOMMUFD_TEST) += selftest.o
 
-obj-$(CONFIG_IOMMUFD) += iommufd.o
+obj-y += iommufd.o
 obj-$(CONFIG_IOMMUFD_DRIVER) += iova_bitmap.o
 
 iommufd_driver-y := driver.o
-- 
2.49.0


-- 
Rolf Eike Beer

emlix GmbH
Headquarters: Berliner Str. 12, 37073 Göttingen, Germany
Phone +49 (0)551 30664-0, e-mail info@emlix.com
District Court of Göttingen, Registry Number HR B 3160
Managing Directors: Heike Jordan, Dr. Uwe Kracke
VAT ID No. DE 205 198 055
Office Berlin: Panoramastr. 1, 10178 Berlin, Germany
Office Bonn: Bachstr. 6, 53115 Bonn, Germany
http://www.emlix.com

emlix - your embedded Linux partner
Re: [PATCH 6/6] iommu: make inclusion of iommufd directory conditional
Posted by Joerg Roedel 7 months ago 
On Mon, May 12, 2025 at 03:15:52PM +0200, Rolf Eike Beer wrote:
> Nothing in there is active if CONFIG_IOMMUFD is not enabled, so the whole
> directory can depend on that switch as well.
> 
> Fixes: 2ff4bed7fee7 ("iommufd: File descriptor, context, kconfig and makefiles")
> Signed-off-by: Rolf Eike Beer <eb@emlix.com>
> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>

Had to remove this patch from the branch as it caused compile breakage
with allmodconfig builds.
Re: [PATCH 6/6] iommu: make inclusion of iommufd directory conditional
Posted by Rolf Eike Beer 6 months, 3 weeks ago 
On Freitag, 16. Mai 2025 14:52:08 Mitteleuropäische Sommerzeit Joerg Roedel 
wrote:
> On Mon, May 12, 2025 at 03:15:52PM +0200, Rolf Eike Beer wrote:
> > Nothing in there is active if CONFIG_IOMMUFD is not enabled, so the whole
> > directory can depend on that switch as well.
> > 
> > Fixes: 2ff4bed7fee7 ("iommufd: File descriptor, context, kconfig and
> > makefiles") Signed-off-by: Rolf Eike Beer <eb@emlix.com>
> > Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
> 
> Had to remove this patch from the branch as it caused compile breakage
> with allmodconfig builds.

Given Arnds fix for smmuv3 this patch may work when the last part in iommufd/
Makefile is omitted.

Regards,

Eike
-- 
Rolf Eike Beer

emlix GmbH
Headquarters: Berliner Str. 12, 37073 Göttingen, Germany
Phone +49 (0)551 30664-0, e-mail info@emlix.com
District Court of Göttingen, Registry Number HR B 3160
Managing Directors: Heike Jordan, Dr. Uwe Kracke
VAT ID No. DE 205 198 055
Office Berlin: Panoramastr. 1, 10178 Berlin, Germany
Office Bonn: Bachstr. 6, 53115 Bonn, Germany
http://www.emlix.com

emlix - your embedded Linux partner
Re: [PATCH 6/6] iommu: make inclusion of iommufd directory conditional
Posted by Rolf Eike Beer 7 months ago 
On Freitag, 16. Mai 2025 14:52:08 Mitteleuropäische Sommerzeit Joerg Roedel 
wrote:
> On Mon, May 12, 2025 at 03:15:52PM +0200, Rolf Eike Beer wrote:
> > Nothing in there is active if CONFIG_IOMMUFD is not enabled, so the whole
> > directory can depend on that switch as well.
> > 
> > Fixes: 2ff4bed7fee7 ("iommufd: File descriptor, context, kconfig and
> > makefiles") Signed-off-by: Rolf Eike Beer <eb@emlix.com>
> > Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
> 
> Had to remove this patch from the branch as it caused compile breakage
> with allmodconfig builds.

I did not catch that this is a tristate, not a bool. The same happens for 
patch 5, which is what the 0-day bot has reported.

Regards,

Eike
-- 
Rolf Eike Beer

emlix GmbH
Headquarters: Berliner Str. 12, 37073 Göttingen, Germany
Phone +49 (0)551 30664-0, e-mail info@emlix.com
District Court of Göttingen, Registry Number HR B 3160
Managing Directors: Heike Jordan, Dr. Uwe Kracke
VAT ID No. DE 205 198 055
Office Berlin: Panoramastr. 1, 10178 Berlin, Germany
Office Bonn: Bachstr. 6, 53115 Bonn, Germany
http://www.emlix.com

emlix - your embedded Linux partner

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.