1. Patchew
  2. linux
  3. View series

[PATCH] arm64: kvm: Replace ternary flags with str_on_off() helper

Seongsu Park posted 1 patch 8 months, 1 week ago 
arch/arm64/kvm/trace_arm.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[PATCH] arm64: kvm: Replace ternary flags with str_on_off() helper
Posted by Seongsu Park 8 months, 1 week ago 
Replace repetitive ternary expressions with the str_on_off() helper
function. This change improves code readability and ensures consistency
in tracepoint string formatting

Signed-off-by: Seongsu Park <sgsu.park@samsung.com>
---
 arch/arm64/kvm/trace_arm.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/kvm/trace_arm.h b/arch/arm64/kvm/trace_arm.h
index c18c1a95831e..9c60f6465c78 100644
--- a/arch/arm64/kvm/trace_arm.h
+++ b/arch/arm64/kvm/trace_arm.h
@@ -176,7 +176,7 @@ TRACE_EVENT(kvm_set_way_flush,
 	    ),
 
 	    TP_printk("S/W flush at 0x%016lx (cache %s)",
-		      __entry->vcpu_pc, __entry->cache ? "on" : "off")
+		      __entry->vcpu_pc, str_on_off(__entry->cache))
 );
 
 TRACE_EVENT(kvm_toggle_cache,
@@ -196,8 +196,8 @@ TRACE_EVENT(kvm_toggle_cache,
 	    ),
 
 	    TP_printk("VM op at 0x%016lx (cache was %s, now %s)",
-		      __entry->vcpu_pc, __entry->was ? "on" : "off",
-		      __entry->now ? "on" : "off")
+		      __entry->vcpu_pc, str_on_off(__entry->was),
+		      str_on_off(__entry->now))
 );
 
 /*
-- 
2.34.1
Re: [PATCH] arm64: kvm: Replace ternary flags with str_on_off() helper
Posted by Marc Zyngier 7 months, 2 weeks ago 
On Tue, 15 Apr 2025 10:24:05 +0900, Seongsu Park wrote:
> Replace repetitive ternary expressions with the str_on_off() helper
> function. This change improves code readability and ensures consistency
> in tracepoint string formatting
> 
> 

Applied to kvm-arm64/misc-6.16, thanks!

[1/1] arm64: kvm: Replace ternary flags with str_on_off() helper
      commit: d2f14174f9e839e1128664ab339bbe17c333208b

Cheers,

	M.
-- 
Without deviation from the norm, progress is not possible.
Re: [PATCH] arm64: kvm: Replace ternary flags with str_on_off() helper
Posted by Zenghui Yu 7 months, 2 weeks ago 
It'd better to write the subject as "KVM: arm64: Replace ..."

On 2025/4/15 9:24, Seongsu Park wrote:
> Replace repetitive ternary expressions with the str_on_off() helper
> function. This change improves code readability and ensures consistency
> in tracepoint string formatting
> 
> Signed-off-by: Seongsu Park <sgsu.park@samsung.com>
> ---
>  arch/arm64/kvm/trace_arm.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Zenghui Yu <yuzenghui@huawei.com>

Thanks,
Zenghui
Re: [PATCH] arm64: kvm: Replace ternary flags with str_on_off() helper
Posted by Anshuman Khandual 8 months, 1 week ago 

On 4/15/25 06:54, Seongsu Park wrote:
> Replace repetitive ternary expressions with the str_on_off() helper
> function. This change improves code readability and ensures consistency
> in tracepoint string formatting
> 
> Signed-off-by: Seongsu Park <sgsu.park@samsung.com>
> ---
>  arch/arm64/kvm/trace_arm.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/kvm/trace_arm.h b/arch/arm64/kvm/trace_arm.h
> index c18c1a95831e..9c60f6465c78 100644
> --- a/arch/arm64/kvm/trace_arm.h
> +++ b/arch/arm64/kvm/trace_arm.h
> @@ -176,7 +176,7 @@ TRACE_EVENT(kvm_set_way_flush,
>  	    ),
>  
>  	    TP_printk("S/W flush at 0x%016lx (cache %s)",
> -		      __entry->vcpu_pc, __entry->cache ? "on" : "off")
> +		      __entry->vcpu_pc, str_on_off(__entry->cache))
>  );
>  
>  TRACE_EVENT(kvm_toggle_cache,
> @@ -196,8 +196,8 @@ TRACE_EVENT(kvm_toggle_cache,
>  	    ),
>  
>  	    TP_printk("VM op at 0x%016lx (cache was %s, now %s)",
> -		      __entry->vcpu_pc, __entry->was ? "on" : "off",
> -		      __entry->now ? "on" : "off")
> +		      __entry->vcpu_pc, str_on_off(__entry->was),
> +		      str_on_off(__entry->now))
>  );
>  
>  /*

Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
RE: [PATCH] arm64: kvm: Replace ternary flags with str_on_off() helper
Posted by Seongsu Park 7 months, 3 weeks ago 

> On 4/15/25 06:54, Seongsu Park wrote:
> > Replace repetitive ternary expressions with the str_on_off() helper
> > function. This change improves code readability and ensures
> > consistency in tracepoint string formatting
> >
> > Signed-off-by: Seongsu Park <sgsu.park@samsung.com>
> > ---
> >  arch/arm64/kvm/trace_arm.h | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm64/kvm/trace_arm.h b/arch/arm64/kvm/trace_arm.h
> > index c18c1a95831e..9c60f6465c78 100644
> > --- a/arch/arm64/kvm/trace_arm.h
> > +++ b/arch/arm64/kvm/trace_arm.h
> > @@ -176,7 +176,7 @@ TRACE_EVENT(kvm_set_way_flush,
> >  	    ),
> >
> >  	    TP_printk("S/W flush at 0x%016lx (cache %s)",
> > -		      __entry->vcpu_pc, __entry->cache ? "on" : "off")
> > +		      __entry->vcpu_pc, str_on_off(__entry->cache))
> >  );
> >
> >  TRACE_EVENT(kvm_toggle_cache,
> > @@ -196,8 +196,8 @@ TRACE_EVENT(kvm_toggle_cache,
> >  	    ),
> >
> >  	    TP_printk("VM op at 0x%016lx (cache was %s, now %s)",
> > -		      __entry->vcpu_pc, __entry->was ? "on" : "off",
> > -		      __entry->now ? "on" : "off")
> > +		      __entry->vcpu_pc, str_on_off(__entry->was),
> > +		      str_on_off(__entry->now))
> >  );
> >
> >  /*
> 
> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>

Dear Anshuman,

Do you have any feedback?
If you have, please let me know.
I think this patch is appropriate.

Thanks.
Seongsu Park.
Re: [PATCH] arm64: kvm: Replace ternary flags with str_on_off() helper
Posted by Marc Zyngier 7 months, 3 weeks ago 
On Mon, 28 Apr 2025 08:11:59 +0100,
"Seongsu Park" <sgsu.park@samsung.com> wrote:
> > On 4/15/25 06:54, Seongsu Park wrote:
> > > Replace repetitive ternary expressions with the str_on_off() helper
> > > function. This change improves code readability and ensures
> > > consistency in tracepoint string formatting
> > >
> > > Signed-off-by: Seongsu Park <sgsu.park@samsung.com>
> > > ---
> > >  arch/arm64/kvm/trace_arm.h | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/arch/arm64/kvm/trace_arm.h b/arch/arm64/kvm/trace_arm.h
> > > index c18c1a95831e..9c60f6465c78 100644
> > > --- a/arch/arm64/kvm/trace_arm.h
> > > +++ b/arch/arm64/kvm/trace_arm.h
> > > @@ -176,7 +176,7 @@ TRACE_EVENT(kvm_set_way_flush,
> > >  	    ),
> > >
> > >  	    TP_printk("S/W flush at 0x%016lx (cache %s)",
> > > -		      __entry->vcpu_pc, __entry->cache ? "on" : "off")
> > > +		      __entry->vcpu_pc, str_on_off(__entry->cache))
> > >  );
> > >
> > >  TRACE_EVENT(kvm_toggle_cache,
> > > @@ -196,8 +196,8 @@ TRACE_EVENT(kvm_toggle_cache,
> > >  	    ),
> > >
> > >  	    TP_printk("VM op at 0x%016lx (cache was %s, now %s)",
> > > -		      __entry->vcpu_pc, __entry->was ? "on" : "off",
> > > -		      __entry->now ? "on" : "off")
> > > +		      __entry->vcpu_pc, str_on_off(__entry->was),
> > > +		      str_on_off(__entry->now))
> > >  );
> > >
> > >  /*
> > 
> > Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
> 
> Dear Anshuman,
> 
> Do you have any feedback?
> If you have, please let me know.
> I think this patch is appropriate.

There isn't much to add. This patch looks reasonable, but it also
doesn't warrant being merged immediately (it is purely cosmetic).

Once I start queuing patches for 6.16, I'll probably add it to the
mix.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.