scsi: ufs: Remove wlun_dev_to_hba()

[PATCH] scsi: ufs: Remove wlun_dev_to_hba()

Posted by Keoseong Park 4 years, 4 months ago

Commit edc0596cc04b ("scsi: ufs: core: Stop clearing UNIT ATTENTIONS")
removed all callers of wlun_dev_to_hba(). Hence also remove the macro itself.

Signed-off-by: Keoseong Park <keosung.park@samsung.com>
---
 drivers/scsi/ufs/ufshcd.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 41d85b69fa50..1243d73d669b 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -83,8 +83,6 @@
 /* Polling time to wait for fDeviceInit */
 #define FDEVICEINIT_COMPL_TIMEOUT 1500 /* millisecs */
 
-#define wlun_dev_to_hba(dv) shost_priv(to_scsi_device(dv)->host)
-
 #define ufshcd_toggle_vreg(_dev, _vreg, _on)				\
 	({                                                              \
 		int _ret;                                               \
-- 
2.17.1

RE: [PATCH] scsi: ufs: Remove wlun_dev_to_hba()

Posted by Alim Akhtar 4 years, 4 months ago


>-----Original Message-----
>From: Keoseong Park [mailto:keosung.park@samsung.com]
>Sent: Tuesday, February 15, 2022 5:10 PM
>To: ALIM AKHTAR <alim.akhtar@samsung.com>; avri.altman@wdc.com;
>jejb@linux.ibm.com; martin.petersen@oracle.com; bvanassche@acm.org;
>beanhuo@micron.com; cang@codeaurora.org; adrian.hunter@intel.com;
>asutoshd@codeaurora.org; linux-scsi@vger.kernel.org; linux-
>kernel@vger.kernel.org
>Subject: [PATCH] scsi: ufs: Remove wlun_dev_to_hba()
>
>Commit edc0596cc04b ("scsi: ufs: core: Stop clearing UNIT ATTENTIONS")
>removed all callers of wlun_dev_to_hba(). Hence also remove the macro
>itself.
>
>Signed-off-by: Keoseong Park <keosung.park@samsung.com>
>---


Thanks!

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

> drivers/scsi/ufs/ufshcd.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index
>41d85b69fa50..1243d73d669b 100644
>--- a/drivers/scsi/ufs/ufshcd.c
>+++ b/drivers/scsi/ufs/ufshcd.c
>@@ -83,8 +83,6 @@
> /* Polling time to wait for fDeviceInit */  #define
>FDEVICEINIT_COMPL_TIMEOUT 1500 /* millisecs */
>
>-#define wlun_dev_to_hba(dv) shost_priv(to_scsi_device(dv)->host)
>-
> #define ufshcd_toggle_vreg(_dev, _vreg, _on)
>	\
> 	({                                                              \
> 		int _ret;                                               \
>--
>2.17.1

Re: [PATCH] scsi: ufs: Remove wlun_dev_to_hba()

Posted by Bart Van Assche 4 years, 4 months ago

On 2/15/22 03:40, Keoseong Park wrote:
> Commit edc0596cc04b ("scsi: ufs: core: Stop clearing UNIT ATTENTIONS")
> removed all callers of wlun_dev_to_hba(). Hence also remove the macro itself.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

Re: [PATCH] scsi: ufs: Remove wlun_dev_to_hba()

Posted by Martin K. Petersen 4 years, 4 months ago

Keoseong,

> Commit edc0596cc04b ("scsi: ufs: core: Stop clearing UNIT ATTENTIONS")
> removed all callers of wlun_dev_to_hba(). Hence also remove the macro
> itself.

Applied to 5.18/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] scsi: ufs: Remove wlun_dev_to_hba()

Posted by Martin K. Petersen 4 years, 3 months ago

On Tue, 15 Feb 2022 20:40:02 +0900, Keoseong Park wrote:

> Commit edc0596cc04b ("scsi: ufs: core: Stop clearing UNIT ATTENTIONS")
> removed all callers of wlun_dev_to_hba(). Hence also remove the macro itself.
> 
> 

Applied to 5.18/scsi-queue, thanks!

[1/1] scsi: ufs: Remove wlun_dev_to_hba()
      https://git.kernel.org/mkp/scsi/c/482dcaa1c91a

-- 
Martin K. Petersen	Oracle Linux Engineering