[PATCH] net: altera: Replace kernel.h with the necessary inclusions

Christophe JAILLET posted 1 patch 3 years, 10 months ago
drivers/net/ethernet/altera/altera_utils.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
[PATCH] net: altera: Replace kernel.h with the necessary inclusions
Posted by Christophe JAILLET 3 years, 10 months ago
When kernel.h is used in the headers it adds a lot into dependency hell,
especially when there are circular dependencies are involved.

Replace kernel.h inclusion with the list of what is really being used.

While at it, move these includes below the include guard.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/net/ethernet/altera/altera_utils.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/altera/altera_utils.h b/drivers/net/ethernet/altera/altera_utils.h
index b7d772f2dcbb..3c2e32fb7389 100644
--- a/drivers/net/ethernet/altera/altera_utils.h
+++ b/drivers/net/ethernet/altera/altera_utils.h
@@ -3,11 +3,12 @@
  * Copyright (C) 2014 Altera Corporation. All rights reserved
  */
 
-#include <linux/kernel.h>
-
 #ifndef __ALTERA_UTILS_H__
 #define __ALTERA_UTILS_H__
 
+#include <linux/compiler.h>
+#include <linux/types.h>
+
 void tse_set_bit(void __iomem *ioaddr, size_t offs, u32 bit_mask);
 void tse_clear_bit(void __iomem *ioaddr, size_t offs, u32 bit_mask);
 int tse_bit_is_set(void __iomem *ioaddr, size_t offs, u32 bit_mask);
-- 
2.34.1
Re: [PATCH] net: altera: Replace kernel.h with the necessary inclusions
Posted by patchwork-bot+netdevbpf@kernel.org 3 years, 10 months ago
Hello:

This patch was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat.com>:

On Sat,  4 Jun 2022 08:54:20 +0200 you wrote:
> When kernel.h is used in the headers it adds a lot into dependency hell,
> especially when there are circular dependencies are involved.
> 
> Replace kernel.h inclusion with the list of what is really being used.
> 
> While at it, move these includes below the include guard.
> 
> [...]

Here is the summary with links:
  - net: altera: Replace kernel.h with the necessary inclusions
    https://git.kernel.org/netdev/net-next/c/12de1ebd2ae3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html