[v4] hwmon: (sht3x) Add support for GXCAS GXHT30

[PATCH v4 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series

Posted by Zaixiang Xu 1 week, 1 day ago

Add YAML devicetree binding schema for Sensirion SHT30 series.
Use fallback compatibles for compatible chips and add optional
interrupts and vdd-supply properties.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/r/202603212044.BRPaiz86-lkp@intel.com/
Signed-off-by: Zaixiang Xu <zaixiang.xu.dev@gmail.com>
---
 .../bindings/hwmon/sensirion,sht30.yaml       | 50 +++++++++++++++++++
 1 file changed, 50 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml

diff --git a/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml b/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
new file mode 100644
index 000000000000..1b5ce822b37b
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/sensirion,sht30.yaml#
+$schema: http://devicetree.org/meta-schema.yaml#
+
+title: Sensirion SHT30 Humidity and Temperature Sensor
+
+maintainers:
+  - Zaixiang Xu <zaixiang.xu.dev@gmail.com>
+
+description: |
+  The SHT30 series is a family of humidity and temperature sensors by Sensirion.
+  Compatible sensors like the GXCAS GXHT30 are also supported.
+
+properties:
+  compatible:
+    enum:
+      - gxcas,gxht30
+      - sensirion,sht30
+      - sensirion,sht31
+      - sensirion,sht35
+      - sensirion,sht85
+      - sensirion,sts30
+      - sensirion,sts31
+      - sensirion,sts32
+      - sensirion,sts35
+
+  reg:
+    maxItems: 1
+    description: I2C address (usually 0x44 or 0x45)
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        sensor@44 {
+            compatible = "gxcas,gxht30";
+            reg = <0x44>;
+        };
+    };
+
-- 
2.34.1

Re: [PATCH v4 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series

Posted by Conor Dooley 1 week, 1 day ago

On Wed, Mar 25, 2026 at 05:08:08PM +0800, Zaixiang Xu wrote:
> Add YAML devicetree binding schema for Sensirion SHT30 series.
> Use fallback compatibles for compatible chips and add optional
> interrupts and vdd-supply properties.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/r/202603212044.BRPaiz86-lkp@intel.com/

The robot did not report that this binding was missing.
It also told you not to add these tags.

You also ignored my and Krzysztof's reviews.

NAK.

pw-bot: changes-requested

> Signed-off-by: Zaixiang Xu <zaixiang.xu.dev@gmail.com>
> ---
>  .../bindings/hwmon/sensirion,sht30.yaml       | 50 +++++++++++++++++++
>  1 file changed, 50 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml b/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
> new file mode 100644
> index 000000000000..1b5ce822b37b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/sensirion,sht30.yaml#
> +$schema: http://devicetree.org/meta-schema.yaml#
> +
> +title: Sensirion SHT30 Humidity and Temperature Sensor
> +
> +maintainers:
> +  - Zaixiang Xu <zaixiang.xu.dev@gmail.com>
> +
> +description: |
> +  The SHT30 series is a family of humidity and temperature sensors by Sensirion.
> +  Compatible sensors like the GXCAS GXHT30 are also supported.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - gxcas,gxht30
> +      - sensirion,sht30
> +      - sensirion,sht31
> +      - sensirion,sht35
> +      - sensirion,sht85
> +      - sensirion,sts30
> +      - sensirion,sts31
> +      - sensirion,sts32
> +      - sensirion,sts35
> +
> +  reg:
> +    maxItems: 1
> +    description: I2C address (usually 0x44 or 0x45)
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        sensor@44 {
> +            compatible = "gxcas,gxht30";
> +            reg = <0x44>;
> +        };
> +    };
> +
> -- 
> 2.34.1
>

Re: [PATCH v4 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series

Posted by Guenter Roeck 1 week, 1 day ago

On 3/25/26 11:20, Conor Dooley wrote:
> On Wed, Mar 25, 2026 at 05:08:08PM +0800, Zaixiang Xu wrote:
>> Add YAML devicetree binding schema for Sensirion SHT30 series.
>> Use fallback compatibles for compatible chips and add optional
>> interrupts and vdd-supply properties.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/r/202603212044.BRPaiz86-lkp@intel.com/
> 
> The robot did not report that this binding was missing.
> It also told you not to add these tags.
> 
> You also ignored my and Krzysztof's reviews.
> 
> NAK.
> 

Maybe we should just point to AI feedback:

https://sashiko.dev/#/patchset/1774429690-129139-1-git-send-email-zaixiang.xu.dev%40gmail.com

and only get involved after AI does not report any problems.

Guenter

> pw-bot: changes-requested
> 
>> Signed-off-by: Zaixiang Xu <zaixiang.xu.dev@gmail.com>
>> ---
>>   .../bindings/hwmon/sensirion,sht30.yaml       | 50 +++++++++++++++++++
>>   1 file changed, 50 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml b/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
>> new file mode 100644
>> index 000000000000..1b5ce822b37b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
>> @@ -0,0 +1,50 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/hwmon/sensirion,sht30.yaml#
>> +$schema: http://devicetree.org/meta-schema.yaml#
>> +
>> +title: Sensirion SHT30 Humidity and Temperature Sensor
>> +
>> +maintainers:
>> +  - Zaixiang Xu <zaixiang.xu.dev@gmail.com>
>> +
>> +description: |
>> +  The SHT30 series is a family of humidity and temperature sensors by Sensirion.
>> +  Compatible sensors like the GXCAS GXHT30 are also supported.
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - gxcas,gxht30
>> +      - sensirion,sht30
>> +      - sensirion,sht31
>> +      - sensirion,sht35
>> +      - sensirion,sht85
>> +      - sensirion,sts30
>> +      - sensirion,sts31
>> +      - sensirion,sts32
>> +      - sensirion,sts35
>> +
>> +  reg:
>> +    maxItems: 1
>> +    description: I2C address (usually 0x44 or 0x45)
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    i2c {
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>> +        sensor@44 {
>> +            compatible = "gxcas,gxht30";
>> +            reg = <0x44>;
>> +        };
>> +    };
>> +
>> -- 
>> 2.34.1
>>

Re: [PATCH v4 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series

Posted by Conor Dooley 1 week ago

On Wed, Mar 25, 2026 at 06:05:22PM -0700, Guenter Roeck wrote:
> On 3/25/26 11:20, Conor Dooley wrote:
> > On Wed, Mar 25, 2026 at 05:08:08PM +0800, Zaixiang Xu wrote:
> > > Add YAML devicetree binding schema for Sensirion SHT30 series.
> > > Use fallback compatibles for compatible chips and add optional
> > > interrupts and vdd-supply properties.
> > > 
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Closes: https://lore.kernel.org/r/202603212044.BRPaiz86-lkp@intel.com/
> > 
> > The robot did not report that this binding was missing.
> > It also told you not to add these tags.
> > 
> > You also ignored my and Krzysztof's reviews.
> > 
> > NAK.
> > 
> 
> Maybe we should just point to AI feedback:
> 
> https://sashiko.dev/#/patchset/1774429690-129139-1-git-send-email-zaixiang.xu.dev%40gmail.com
> 
> and only get involved after AI does not report any problems.
> 

The presentation of info in that is weird, it creates a pseudo-commit
message, and then goes on to talk about things that the pseudo-commit
message has had culled.

Re: [PATCH v4 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series

Posted by Conor Dooley 1 week ago

On Thu, Mar 26, 2026 at 05:42:30PM +0000, Conor Dooley wrote:
> On Wed, Mar 25, 2026 at 06:05:22PM -0700, Guenter Roeck wrote:
> > On 3/25/26 11:20, Conor Dooley wrote:
> > > On Wed, Mar 25, 2026 at 05:08:08PM +0800, Zaixiang Xu wrote:
> > > > Add YAML devicetree binding schema for Sensirion SHT30 series.
> > > > Use fallback compatibles for compatible chips and add optional
> > > > interrupts and vdd-supply properties.
> > > > 
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > Closes: https://lore.kernel.org/r/202603212044.BRPaiz86-lkp@intel.com/
> > > 
> > > The robot did not report that this binding was missing.
> > > It also told you not to add these tags.
> > > 
> > > You also ignored my and Krzysztof's reviews.
> > > 
> > > NAK.
> > > 
> > 
> > Maybe we should just point to AI feedback:
> > 
> > https://sashiko.dev/#/patchset/1774429690-129139-1-git-send-email-zaixiang.xu.dev%40gmail.com
> > 
> > and only get involved after AI does not report any problems.
> > 
> 
> The presentation of info in that is weird, it creates a pseudo-commit
> message, and then goes on to talk about things that the pseudo-commit
> message has had culled.

How good is this LLM stuff at figuring out if previous review feedback
has been resolved? Or is it not capable of looking at earlier revisions?

Re: [PATCH v4 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series

Posted by Guenter Roeck 1 week ago

On 3/26/26 10:45, Conor Dooley wrote:
> On Thu, Mar 26, 2026 at 05:42:30PM +0000, Conor Dooley wrote:
>> On Wed, Mar 25, 2026 at 06:05:22PM -0700, Guenter Roeck wrote:
>>> On 3/25/26 11:20, Conor Dooley wrote:
>>>> On Wed, Mar 25, 2026 at 05:08:08PM +0800, Zaixiang Xu wrote:
>>>>> Add YAML devicetree binding schema for Sensirion SHT30 series.
>>>>> Use fallback compatibles for compatible chips and add optional
>>>>> interrupts and vdd-supply properties.
>>>>>
>>>>> Reported-by: kernel test robot <lkp@intel.com>
>>>>> Closes: https://lore.kernel.org/r/202603212044.BRPaiz86-lkp@intel.com/
>>>>
>>>> The robot did not report that this binding was missing.
>>>> It also told you not to add these tags.
>>>>
>>>> You also ignored my and Krzysztof's reviews.
>>>>
>>>> NAK.
>>>>
>>>
>>> Maybe we should just point to AI feedback:
>>>
>>> https://sashiko.dev/#/patchset/1774429690-129139-1-git-send-email-zaixiang.xu.dev%40gmail.com
>>>
>>> and only get involved after AI does not report any problems.
>>>
>>
>> The presentation of info in that is weird, it creates a pseudo-commit
>> message, and then goes on to talk about things that the pseudo-commit
>> message has had culled.
> 
> How good is this LLM stuff at figuring out if previous review feedback
> has been resolved? Or is it not capable of looking at earlier revisions?


Both are interesting questions. For the first one, I had noticed that, but
to me it seemed that the pseudo-commit message is an attempt to create a concise
version of the commit message, and I have not seen evidence that the later
comments did not also apply to the real commit message.

Anyway, copying Roman for feedback on both.

Thanks,
Guenter

Re: [PATCH v4 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series

Posted by Conor Dooley 1 week ago

On Thu, Mar 26, 2026 at 04:55:39PM -0700, Guenter Roeck wrote:
> On 3/26/26 10:45, Conor Dooley wrote:
> > On Thu, Mar 26, 2026 at 05:42:30PM +0000, Conor Dooley wrote:
> > > On Wed, Mar 25, 2026 at 06:05:22PM -0700, Guenter Roeck wrote:
> > > > On 3/25/26 11:20, Conor Dooley wrote:
> > > > > On Wed, Mar 25, 2026 at 05:08:08PM +0800, Zaixiang Xu wrote:
> > > > > > Add YAML devicetree binding schema for Sensirion SHT30 series.
> > > > > > Use fallback compatibles for compatible chips and add optional
> > > > > > interrupts and vdd-supply properties.
> > > > > > 
> > > > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > > > Closes: https://lore.kernel.org/r/202603212044.BRPaiz86-lkp@intel.com/
> > > > > 
> > > > > The robot did not report that this binding was missing.
> > > > > It also told you not to add these tags.
> > > > > 
> > > > > You also ignored my and Krzysztof's reviews.
> > > > > 
> > > > > NAK.
> > > > > 
> > > > 
> > > > Maybe we should just point to AI feedback:
> > > > 
> > > > https://sashiko.dev/#/patchset/1774429690-129139-1-git-send-email-zaixiang.xu.dev%40gmail.com
> > > > 
> > > > and only get involved after AI does not report any problems.
> > > > 
> > > 
> > > The presentation of info in that is weird, it creates a pseudo-commit
> > > message, and then goes on to talk about things that the pseudo-commit
> > > message has had culled.
> > 
> > How good is this LLM stuff at figuring out if previous review feedback
> > has been resolved? Or is it not capable of looking at earlier revisions?
> 
> 
> Both are interesting questions. For the first one, I had noticed that, but
> to me it seemed that the pseudo-commit message is an attempt to create a concise
> version of the commit message, and I have not seen evidence that the later
> comments did not also apply to the real commit message.

Yeah, the comments did apply to the real commit message. I was just
confusing to me to see what looked to me like a commit message not
contain the info that was being referred to later on. I thought that the
LLM was hallucinating the comments until I went back to this mail and
realised the text was here.

> 
> Anyway, copying Roman for feedback on both.
> 
> Thanks,
> Guenter
>

Re: [PATCH v4 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series

Posted by Roman Gushchin 1 week ago

Hello,

The pseudo-commit message is intentional, Chris Mason initially
prompted it, and I'm honestly just using his format. The intention
here is to ensure the LLM reviews the correct commit and at least
understands what it's doing. Idk if it's really useful with Sashiko,
but it's there and hopefully not too distracting.

Re previous versions: it's not implemented yet, but I plan to add this
eventually.

Thanks!


On Thu, Mar 26, 2026 at 5:03 PM Conor Dooley <conor@kernel.org> wrote:
>
> On Thu, Mar 26, 2026 at 04:55:39PM -0700, Guenter Roeck wrote:
> > On 3/26/26 10:45, Conor Dooley wrote:
> > > On Thu, Mar 26, 2026 at 05:42:30PM +0000, Conor Dooley wrote:
> > > > On Wed, Mar 25, 2026 at 06:05:22PM -0700, Guenter Roeck wrote:
> > > > > On 3/25/26 11:20, Conor Dooley wrote:
> > > > > > On Wed, Mar 25, 2026 at 05:08:08PM +0800, Zaixiang Xu wrote:
> > > > > > > Add YAML devicetree binding schema for Sensirion SHT30 series.
> > > > > > > Use fallback compatibles for compatible chips and add optional
> > > > > > > interrupts and vdd-supply properties.
> > > > > > >
> > > > > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > > > > Closes: https://lore.kernel.org/r/202603212044.BRPaiz86-lkp@intel.com/
> > > > > >
> > > > > > The robot did not report that this binding was missing.
> > > > > > It also told you not to add these tags.
> > > > > >
> > > > > > You also ignored my and Krzysztof's reviews.
> > > > > >
> > > > > > NAK.
> > > > > >
> > > > >
> > > > > Maybe we should just point to AI feedback:
> > > > >
> > > > > https://sashiko.dev/#/patchset/1774429690-129139-1-git-send-email-zaixiang.xu.dev%40gmail.com
> > > > >
> > > > > and only get involved after AI does not report any problems.
> > > > >
> > > >
> > > > The presentation of info in that is weird, it creates a pseudo-commit
> > > > message, and then goes on to talk about things that the pseudo-commit
> > > > message has had culled.
> > >
> > > How good is this LLM stuff at figuring out if previous review feedback
> > > has been resolved? Or is it not capable of looking at earlier revisions?
> >
> >
> > Both are interesting questions. For the first one, I had noticed that, but
> > to me it seemed that the pseudo-commit message is an attempt to create a concise
> > version of the commit message, and I have not seen evidence that the later
> > comments did not also apply to the real commit message.
>
> Yeah, the comments did apply to the real commit message. I was just
> confusing to me to see what looked to me like a commit message not
> contain the info that was being referred to later on. I thought that the
> LLM was hallucinating the comments until I went back to this mail and
> realised the text was here.
>
> >
> > Anyway, copying Roman for feedback on both.
> >
> > Thanks,
> > Guenter
> >