[v1] sched/fair: Fix comma operator misuse in NUMA fault accounting

[tip: sched/core] sched/fair: Fix comma operator misuse in NUMA fault accounting

tip-bot2 for Zhan Xusheng posted 1 patch 3 weeks, 5 days ago

Diff against v1
Download mbox

kernel/sched/fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[tip: sched/core] sched/fair: Fix comma operator misuse in NUMA fault accounting

Posted by tip-bot2 for Zhan Xusheng 3 weeks, 5 days ago

The following commit has been merged into the sched/core branch of tip:

Commit-ID:     8d16e3c6f844823812f872df5ef1d3d2ed11b956
Gitweb:        https://git.kernel.org/tip/8d16e3c6f844823812f872df5ef1d3d2ed11b956
Author:        Zhan Xusheng <zhanxusheng1024@gmail.com>
AuthorDate:    Mon, 09 Mar 2026 10:42:47 +08:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Thu, 12 Mar 2026 07:47:37 +01:00

sched/fair: Fix comma operator misuse in NUMA fault accounting

Replace the comma operator with separate statements when assigning
NUMA fault statistics. This improves readability and follows kernel
coding style.

Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://patch.msgid.link/20260309024247.10908-1-zhanxusheng@xiaomi.com
---
 kernel/sched/fair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index d57c02e..c1e5c82 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -14226,7 +14226,7 @@ void show_numa_stats(struct task_struct *p, struct seq_file *m)
 			tpf = p->numa_faults[task_faults_idx(NUMA_MEM, node, 1)];
 		}
 		if (ng) {
-			gsf = ng->faults[task_faults_idx(NUMA_MEM, node, 0)],
+			gsf = ng->faults[task_faults_idx(NUMA_MEM, node, 0)];
 			gpf = ng->faults[task_faults_idx(NUMA_MEM, node, 1)];
 		}
 		print_numa_stats(m, node, tsf, tpf, gsf, gpf);