[tip: objtool/core] objtool/klp: Remove redundant strcmp() in correlate_symbols()

tip-bot2 for Song Liu posted 1 patch 1 month ago
tools/objtool/klp-diff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[tip: objtool/core] objtool/klp: Remove redundant strcmp() in correlate_symbols()
Posted by tip-bot2 for Song Liu 1 month ago
The following commit has been merged into the objtool/core branch of tip:

Commit-ID:     a1cbaff2ea23645f0a94fdfa721aef202aebdf86
Gitweb:        https://git.kernel.org/tip/a1cbaff2ea23645f0a94fdfa721aef202aebdf86
Author:        Song Liu <song@kernel.org>
AuthorDate:    Thu, 05 Mar 2026 15:15:25 -08:00
Committer:     Josh Poimboeuf <jpoimboe@kernel.org>
CommitterDate: Fri, 06 Mar 2026 08:08:23 -08:00

objtool/klp: Remove redundant strcmp() in correlate_symbols()

find_global_symbol_by_name() already compares names of the two symbols,
so there is no need to compare them again.

Signed-off-by: Song Liu <song@kernel.org>
Link: https://patch.msgid.link/20260305231531.3847295-2-song@kernel.org
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
---
 tools/objtool/klp-diff.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/objtool/klp-diff.c b/tools/objtool/klp-diff.c
index 885775f..639bdd3 100644
--- a/tools/objtool/klp-diff.c
+++ b/tools/objtool/klp-diff.c
@@ -454,7 +454,7 @@ static int correlate_symbols(struct elfs *e)
 
 		sym2 = find_global_symbol_by_name(e->patched, sym1->name);
 
-		if (sym2 && !sym2->twin && !strcmp(sym1->name, sym2->name)) {
+		if (sym2 && !sym2->twin) {
 			sym1->twin = sym2;
 			sym2->twin = sym1;
 		}