Hi,
This series by Cosmin and Jiri adds support for cross-function rate
scheduling in devlink and mlx5.
See detailed explanation by Cosmin below [1].
Regards,
Tariq
[1]
devlink objects support rate management for TX scheduling, which
involves maintaining a tree of rate nodes that corresponds to TX
schedulers in hardware. 'man devlink-rate' has the full details.
The tree of rate nodes is maintained per devlink object, protected by
the devlink lock.
There exists hardware capable of instantiating TX scheduling trees
spanning multiple functions of the same physical device (and thus
devlink objects) and therefore the current API and locking scheme is
insufficient.
This patch series changes the devlink rate implementation and API to
allow supporting such hardware and managing TX scheduling trees across
multiple functions of a physical device.
Modeling this requires having devlink rate nodes with parents in other
devlink objects. A naive approach that relies on the current
one-lock-per-devlink model is impossible, as it would require in some
cases acquiring multiple devlink locks in the correct order.
The solution proposed in this patch series consists of two parts:
1. Representing the underlying physical NIC as a shared devlink object
on the faux bus and nesting all its PF devlink instances in it.
2. Changing the devlink rate implementation to store rates in this
shared devlink object, if it exists, and use its lock to protect
against concurrent changes of the scheduling tree.
With these in place, cross-esw scheduling support is added to mlx5.
The neat part about this approach is that it works for SFs as well,
which are already nested in their parent PF instances. So with this
series, complex scheduling trees spanning multiple SFs across multiple
PFs of the same NIC can now be supported.
V1 of this patch series was sent a long time ago [2], using a different
approach of storing rates in a shared rate domain with special locking
rules. This new approach uses standard devlink instances and nesting.
Patches:
devlink rate changes for cross-device TX scheduling:
devlink: Reverse locking order for nested instances
documentation: networking: add shared devlink documentation
devlink: Add helpers to lock nested-in instances
devlink: Refactor devlink_rate_nodes_check
devlink: Decouple rate storage from associated devlink object
devlink: Add parent dev to devlink API
devlink: Allow parent dev for rate-set and rate-new
devlink: Allow rate node parents from other devlinks
devlink: introduce shared devlink instance for PFs on same chip
mlx5 support for cross-device TX scheduling:
net/mlx5: Add a shared devlink instance for PFs on same chip
net/mlx5: Expose a function to clear a vport's parent
net/mlx5: Store QoS sched nodes in the sh_devlink
net/mlx5: qos: Support cross-esw tx scheduling
net/mlx5: Document devlink rates and cross-esw scheduling
[2] https://lore.kernel.org/netdev/20250213180134.323929-1-tariqt@nvidia.com/
V6:
- Really stopped using __free (Krzysztof Kozlowski).
- Fixed incorrect state->idx usage in rate dump (AI tool).
- Merged patches V5.12 and V5.14 to close a bisect bug (AI tool).
- Link to V5: https://lore.kernel.org/all/1768895878-1637182-1-git-send-email-tariqt@nvidia.com/
V5:
- Made parts of shd generic devlink infra (Jakub).
- Stopped using __free (Krzysztof Kozlowski).
- Moved some generated netlink in the correct patch (Simon Horman).
- Addressed cleanup bug (Jakub).
- Clarified uses of shared devlink in documentation.
V4:
- Fix typo in documentation (Randy Dunlap).
V3:
- Remove mistakenly repeated devlink interface in docs (Jakub).
- Add Jiri's review tags on ML.
V2:
- Rebase.
- Add Jiri's review tags on ML.
Cosmin Ratiu (11):
devlink: Reverse locking order for nested instances
devlink: Add helpers to lock nested-in instances
devlink: Refactor devlink_rate_nodes_check
devlink: Decouple rate storage from associated devlink object
devlink: Add parent dev to devlink API
devlink: Allow parent dev for rate-set and rate-new
devlink: Allow rate node parents from other devlinks
net/mlx5: Expose a function to clear a vport's parent
net/mlx5: Store QoS sched nodes in the sh_devlink
net/mlx5: qos: Support cross-device tx scheduling
net/mlx5: Document devlink rates
Jiri Pirko (3):
documentation: networking: add shared devlink documentation
devlink: introduce shared devlink instance for PFs on same chip
net/mlx5: Add a shared devlink instance for PFs on same chip
Documentation/netlink/specs/devlink.yaml | 22 +-
.../networking/devlink/devlink-port.rst | 2 +
.../networking/devlink/devlink-shared.rst | 94 +++++
Documentation/networking/devlink/index.rst | 1 +
Documentation/networking/devlink/mlx5.rst | 33 ++
.../net/ethernet/mellanox/mlx5/core/Makefile | 5 +-
.../net/ethernet/mellanox/mlx5/core/devlink.c | 1 +
.../mellanox/mlx5/core/esw/devlink_port.c | 2 +-
.../net/ethernet/mellanox/mlx5/core/esw/qos.c | 332 ++++++++----------
.../net/ethernet/mellanox/mlx5/core/esw/qos.h | 3 -
.../net/ethernet/mellanox/mlx5/core/eswitch.c | 9 +-
.../net/ethernet/mellanox/mlx5/core/eswitch.h | 14 +-
.../net/ethernet/mellanox/mlx5/core/main.c | 17 +
.../ethernet/mellanox/mlx5/core/sh_devlink.c | 99 ++++++
.../ethernet/mellanox/mlx5/core/sh_devlink.h | 14 +
include/linux/mlx5/driver.h | 1 +
include/net/devlink.h | 13 +
include/uapi/linux/devlink.h | 2 +
net/devlink/Makefile | 2 +-
net/devlink/core.c | 48 ++-
net/devlink/dev.c | 7 +-
net/devlink/devl_internal.h | 11 +-
net/devlink/netlink.c | 67 +++-
net/devlink/netlink_gen.c | 23 +-
net/devlink/netlink_gen.h | 8 +
net/devlink/rate.c | 290 +++++++++++----
net/devlink/sh_dev.c | 163 +++++++++
27 files changed, 984 insertions(+), 299 deletions(-)
create mode 100644 Documentation/networking/devlink/devlink-shared.rst
create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/sh_devlink.c
create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/sh_devlink.h
create mode 100644 net/devlink/sh_dev.c
base-commit: eac026ff97a9447d34113dd7c4adbcd185185142
--
2.40.1