[tip: x86/sev] x86/startup/sev: Document the CPUID flow in the boot #VC handler

tip-bot2 for Tom Lendacky posted 1 patch 6 hours ago
arch/x86/boot/startup/sev-shared.c | 11 +++++++++++
1 file changed, 11 insertions(+)
[tip: x86/sev] x86/startup/sev: Document the CPUID flow in the boot #VC handler
Posted by tip-bot2 for Tom Lendacky 6 hours ago
The following commit has been merged into the x86/sev branch of tip:

Commit-ID:     8d73829b78ca1a0e6eb93380f3bf5193d58c281c
Gitweb:        https://git.kernel.org/tip/8d73829b78ca1a0e6eb93380f3bf5193d58c281c
Author:        Tom Lendacky <thomas.lendacky@amd.com>
AuthorDate:    Wed, 10 Sep 2025 17:19:28 +02:00
Committer:     Borislav Petkov (AMD) <bp@alien8.de>
CommitterDate: Wed, 10 Sep 2025 17:23:24 +02:00

x86/startup/sev: Document the CPUID flow in the boot #VC handler

Document the CPUID reading the different SEV guest types do - the SNP
one which relies on the presence of a CPUID table and the SEV-ES one,
which reads the CPUID supplied by the hypervisor.

The intent being to clarify the two back-to-back, similar CPUID
invocations.

No functional changes.

  [ bp: Turn into a proper patch. ]

Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/fbb24767-0e06-d1d6-36e0-1757d98aca66@amd.com
---
 arch/x86/boot/startup/sev-shared.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/x86/boot/startup/sev-shared.c b/arch/x86/boot/startup/sev-shared.c
index 08cc156..4e22ffd 100644
--- a/arch/x86/boot/startup/sev-shared.c
+++ b/arch/x86/boot/startup/sev-shared.c
@@ -458,6 +458,13 @@ void do_vc_no_ghcb(struct pt_regs *regs, unsigned long exit_code)
 	leaf.fn = fn;
 	leaf.subfn = subfn;
 
+	/*
+	 * If SNP is active, then snp_cpuid() uses the CPUID table to obtain the
+	 * CPUID values (with possible HV interaction during post-processing of
+	 * the values). But if SNP is not active (no CPUID table present), then
+	 * snp_cpuid() returns -EOPNOTSUPP so that an SEV-ES guest can call the
+	 * HV to obtain the CPUID information.
+	 */
 	ret = snp_cpuid(snp_cpuid_hv_msr, NULL, &leaf);
 	if (!ret)
 		goto cpuid_done;
@@ -465,6 +472,10 @@ void do_vc_no_ghcb(struct pt_regs *regs, unsigned long exit_code)
 	if (ret != -EOPNOTSUPP)
 		goto fail;
 
+	/*
+	 * This is reached by a SEV-ES guest and needs to invoke the HV for
+	 * the CPUID data.
+	 */
 	if (__sev_cpuid_hv_msr(&leaf))
 		goto fail;