[PATCH v2 1/4] dt-bindings: memory-controllers: renesas,rpc-if: Add RZ/A1 and RZ/A2 compat strings

Magnus Damm posted 4 patches 2 months, 3 weeks ago
[PATCH v2 1/4] dt-bindings: memory-controllers: renesas,rpc-if: Add RZ/A1 and RZ/A2 compat strings
Posted by Magnus Damm 2 months, 3 weeks ago
From: Magnus Damm <damm@opensource.se>

Add RZ/A1 and RZ/A2 compat strings for the renesas rpc-if device.

Signed-off-by: Magnus Damm <damm@opensource.se>
---

 Changes since v1:
 - Moved RZ/A to top of RZ

 Applies to next-20250710

 Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml |    5 +++++
 1 file changed, 5 insertions(+)

--- 0001/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
+++ work/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml	2025-07-11 04:50:41.505855241 +0900
@@ -50,6 +50,11 @@ properties:
 
       - items:
           - enum:
+	      - renesas,r7s72100-rpc-if       # RZ/A1H
+	      - renesas,r7s9210-rpc-if        # RZ/A2M
+
+      - items:
+          - enum:
               - renesas,r9a07g043-rpc-if      # RZ/G2UL
               - renesas,r9a07g044-rpc-if      # RZ/G2{L,LC}
               - renesas,r9a07g054-rpc-if      # RZ/V2L
Re: [PATCH v2 1/4] dt-bindings: memory-controllers: renesas,rpc-if: Add RZ/A1 and RZ/A2 compat strings
Posted by Rob Herring (Arm) 2 months, 3 weeks ago
On Sat, 12 Jul 2025 15:39:27 +0200, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> Add RZ/A1 and RZ/A2 compat strings for the renesas rpc-if device.
> 
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
> 
>  Changes since v1:
>  - Moved RZ/A to top of RZ
> 
>  Applies to next-20250710
> 
>  Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> --- 0001/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> +++ work/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml	2025-07-11 04:50:41.505855241 +0900
> @@ -50,6 +50,11 @@ properties:
> 
>        - items:
>            - enum:
> +	      - renesas,r7s72100-rpc-if       # RZ/A1H
> +	      - renesas,r7s9210-rpc-if        # RZ/A2M
> +
> +      - items:
> +          - enum:
>                - renesas,r9a07g043-rpc-if      # RZ/G2UL
>                - renesas,r9a07g044-rpc-if      # RZ/G2{L,LC}
>                - renesas,r9a07g054-rpc-if      # RZ/V2L
> 
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml:53:1: [error] syntax error: found character '\t' that cannot start any token (syntax)

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml: ignoring, error parsing file
./Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml:53:1: found character that cannot start any token
make[2]: *** Deleting file 'Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.example.dts'
Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml:53:1: found character that cannot start any token
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1525: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/175232756792.19062.3922882730162396395.sendpatchset@1.0.0.127.in-addr.arpa

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v2 1/4] dt-bindings: memory-controllers: renesas,rpc-if: Add RZ/A1 and RZ/A2 compat strings
Posted by Krzysztof Kozlowski 2 months, 3 weeks ago
On 12/07/2025 15:39, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> Add RZ/A1 and RZ/A2 compat strings for the renesas rpc-if device.
> 
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
> 
>  Changes since v1:
>  - Moved RZ/A to top of RZ
> 
>  Applies to next-20250710
> 
>  Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> --- 0001/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> +++ work/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml	2025-07-11 04:50:41.505855241 +0900
> @@ -50,6 +50,11 @@ properties:
>  
>        - items:
>            - enum:
> +	      - renesas,r7s72100-rpc-if       # RZ/A1H
> +	      - renesas,r7s9210-rpc-if        # RZ/A2M

Still not tested.

You got extensive guideline from me last time. You just replied (in
private!) that you are not going to install dtschema and test it.

Fine if you send correct code.

Not fine if you write buggy code. And this is obviously the case here as
easily visible in the diff above - borken indentation.

Please read carefully previous instructions.

Best regards,
Krzysztof