[PATCH net-next 0/5] net/mlx5: Convert mlx5 to netdev instance locking

Tariq Toukan posted 5 patches 6 months, 3 weeks ago
drivers/infiniband/ulp/ipoib/ipoib.h          |  13 +-
drivers/infiniband/ulp/ipoib/ipoib_ib.c       |  65 ++++++---
drivers/infiniband/ulp/ipoib/ipoib_main.c     | 127 ++++++++++++------
drivers/infiniband/ulp/ipoib/ipoib_verbs.c    |   8 +-
drivers/infiniband/ulp/ipoib/ipoib_vlan.c     |  19 +--
.../ethernet/mellanox/mlx5/core/en/health.c   |   2 +
.../net/ethernet/mellanox/mlx5/core/en/ptp.c  |  25 +++-
.../mellanox/mlx5/core/en/reporter_tx.c       |   4 -
.../net/ethernet/mellanox/mlx5/core/en/trap.c |  12 +-
.../ethernet/mellanox/mlx5/core/en_dcbnl.c    |   2 +
.../ethernet/mellanox/mlx5/core/en_ethtool.c  |   5 -
.../net/ethernet/mellanox/mlx5/core/en_fs.c   |   4 +
.../net/ethernet/mellanox/mlx5/core/en_main.c |  82 ++++++-----
.../net/ethernet/mellanox/mlx5/core/en_rep.c  |   7 +
.../ethernet/mellanox/mlx5/core/ipoib/ipoib.c |   3 +
15 files changed, 246 insertions(+), 132 deletions(-)
[PATCH net-next 0/5] net/mlx5: Convert mlx5 to netdev instance locking
Posted by Tariq Toukan 6 months, 3 weeks ago
Hi,

This series by Cosmin converts mlx5 to use the recently added netdev
instance locking scheme.

Find detailed description by Cosmin below [1].

Regards,
Tariq

[1]
mlx5 manages multiple netdevices, from basic Ethernet to Infiniband
netdevs. This patch series converts the driver to use netdev instance
locking for everything in preparation for TCP devmem Zero Copy.

Because mlx5 is tightly coupled with the ipoib driver, a series of
changes first happen in ipoib to allow it to work with mlx5 netdevs that
use instance locking:

IB/IPoIB: Enqueue separate work_structs for each flushed interface
IB/IPoIB: Replace vlan_rwsem with the netdev instance lock
IB/IPoIB: Allow using netdevs that require the instance lock

A small patch then avoids dropping RTNL during firmware update:
net/mlx5e: Don't drop RTNL during firmware flash

The main patch then converts all mlx5 netdevs to use instance locking:
net/mlx5e: Convert mlx5 netdevs to instance locking


Cosmin Ratiu (5):
  IB/IPoIB: Enqueue separate work_structs for each flushed interface
  IB/IPoIB: Replace vlan_rwsem with the netdev instance lock
  IB/IPoIB: Allow using netdevs that require the instance lock
  net/mlx5e: Don't drop RTNL during firmware flash
  net/mlx5e: Convert mlx5 netdevs to instance locking

 drivers/infiniband/ulp/ipoib/ipoib.h          |  13 +-
 drivers/infiniband/ulp/ipoib/ipoib_ib.c       |  65 ++++++---
 drivers/infiniband/ulp/ipoib/ipoib_main.c     | 127 ++++++++++++------
 drivers/infiniband/ulp/ipoib/ipoib_verbs.c    |   8 +-
 drivers/infiniband/ulp/ipoib/ipoib_vlan.c     |  19 +--
 .../ethernet/mellanox/mlx5/core/en/health.c   |   2 +
 .../net/ethernet/mellanox/mlx5/core/en/ptp.c  |  25 +++-
 .../mellanox/mlx5/core/en/reporter_tx.c       |   4 -
 .../net/ethernet/mellanox/mlx5/core/en/trap.c |  12 +-
 .../ethernet/mellanox/mlx5/core/en_dcbnl.c    |   2 +
 .../ethernet/mellanox/mlx5/core/en_ethtool.c  |   5 -
 .../net/ethernet/mellanox/mlx5/core/en_fs.c   |   4 +
 .../net/ethernet/mellanox/mlx5/core/en_main.c |  82 ++++++-----
 .../net/ethernet/mellanox/mlx5/core/en_rep.c  |   7 +
 .../ethernet/mellanox/mlx5/core/ipoib/ipoib.c |   3 +
 15 files changed, 246 insertions(+), 132 deletions(-)


base-commit: f685204c57e87d2a88b159c7525426d70ee745c9
-- 
2.31.1
Re: [PATCH net-next 0/5] net/mlx5: Convert mlx5 to netdev instance locking
Posted by Jakub Kicinski 6 months, 3 weeks ago
On Wed, 21 May 2025 15:08:57 +0300 Tariq Toukan wrote:
> This series by Cosmin converts mlx5 to use the recently added netdev
> instance locking scheme.

Are you planning to re-submit this as a PR?
The subject tag and Leon's reviews being present makes me think
that applying directly is fine, but I wanted to confirm..
Re: [PATCH net-next 0/5] net/mlx5: Convert mlx5 to netdev instance locking
Posted by Leon Romanovsky 6 months, 3 weeks ago
On Thu, May 22, 2025 at 08:51:32AM -0700, Jakub Kicinski wrote:
> On Wed, 21 May 2025 15:08:57 +0300 Tariq Toukan wrote:
> > This series by Cosmin converts mlx5 to use the recently added netdev
> > instance locking scheme.
> 
> Are you planning to re-submit this as a PR?
> The subject tag and Leon's reviews being present makes me think
> that applying directly is fine, but I wanted to confirm..

Yes, please apply them directly. There are no changes in IPoIB in this
cycle, so it will be safe to merge the code through netdev.

Cosmin added my ROB tags, after internal review, so I didn't want to be silly
and send my Acked-by in addition to already existing tags.

Thanks