dt-bindings: usb: dwc3-xilinx: allow dma-coherent

[PATCH] dt-bindings: usb: dwc3-xilinx: allow dma-coherent

Posted by Radhey Shyam Pandey 7 months, 1 week ago

On Versal Gen 2 SoC the LPD USB DMA controller is coherent with the CPU
so allow specifying the information.

Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
---
 Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml b/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml
index 379dacacb526..36f5c644d959 100644
--- a/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml
+++ b/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml
@@ -26,6 +26,8 @@ properties:
 
   ranges: true
 
+  dma-coherent: true
+
   power-domains:
     description: specifies a phandle to PM domain provider node
     maxItems: 1

base-commit: 8566fc3b96539e3235909d6bdda198e1282beaed
-- 
2.34.1

Re: [PATCH] dt-bindings: usb: dwc3-xilinx: allow dma-coherent

Posted by Rob Herring (Arm) 6 months, 3 weeks ago

On Fri, 16 May 2025 18:48:36 +0530, Radhey Shyam Pandey wrote:
> On Versal Gen 2 SoC the LPD USB DMA controller is coherent with the CPU
> so allow specifying the information.
> 
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> ---
>  Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

Applied, thanks!

Re: [PATCH] dt-bindings: usb: dwc3-xilinx: allow dma-coherent

Posted by Conor Dooley 7 months, 1 week ago

On Fri, May 16, 2025 at 06:48:36PM +0530, Radhey Shyam Pandey wrote:
> On Versal Gen 2 SoC the LPD USB DMA controller is coherent with the CPU
> so allow specifying the information.

Sounds like it should actually be marked required on this platform, no?

> 
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> ---
>  Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml b/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml
> index 379dacacb526..36f5c644d959 100644
> --- a/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml
> +++ b/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml
> @@ -26,6 +26,8 @@ properties:
>  
>    ranges: true
>  
> +  dma-coherent: true
> +
>    power-domains:
>      description: specifies a phandle to PM domain provider node
>      maxItems: 1
> 
> base-commit: 8566fc3b96539e3235909d6bdda198e1282beaed
> -- 
> 2.34.1
>

Re: [PATCH] dt-bindings: usb: dwc3-xilinx: allow dma-coherent

Posted by Rob Herring 6 months, 3 weeks ago

On Fri, May 16, 2025 at 03:16:02PM +0100, Conor Dooley wrote:
> On Fri, May 16, 2025 at 06:48:36PM +0530, Radhey Shyam Pandey wrote:
> > On Versal Gen 2 SoC the LPD USB DMA controller is coherent with the CPU
> > so allow specifying the information.
> 
> Sounds like it should actually be marked required on this platform, no?

Should still work without it, just more overhead of unnecessary cache 
flushes.

Rob