[v1] vmstat: call fold_vm_zone_numa_events() before show per zone NUMA event

[PATCH] vmstat: call fold_vm_zone_numa_events() before show per zone NUMA event

Posted by mengensun88@gmail.com 3 weeks, 4 days ago

From: MengEn Sun <mengensun@tencent.com>

NUMA events will only be folded from per-CPU statistics to per
zone and global statistics when the user actually needs it.

So, we perform this folding when reading the /proc/zoneinfo

Fixes: f19298b9516c ("mm/vmstat: convert NUMA statistics to basic NUMA counters")
Reviewed-by: JinLiang Zheng <alexjlzheng@tencent.com>
Signed-off-by: MengEn Sun <mengensun@tencent.com>
---
 mm/vmstat.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/vmstat.c b/mm/vmstat.c
index b5a4cea..2770800 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -1778,6 +1778,7 @@ static void zoneinfo_show_print(struct seq_file *m, pg_data_t *pgdat,
 			   zone_page_state(zone, i));
 
 #ifdef CONFIG_NUMA
+	fold_vm_zone_numa_events(zone);
 	for (i = 0; i < NR_VM_NUMA_EVENT_ITEMS; i++)
 		seq_printf(m, "\n      %-12s %lu", numa_stat_name(i),
 			   zone_numa_event_state(zone, i));
-- 
1.8.3.1

Re: [PATCH] vmstat: call fold_vm_zone_numa_events() before show per zone NUMA event

Posted by Andrew Morton 3 weeks, 4 days ago

On Wed, 30 Oct 2024 16:37:37 +0800 mengensun88@gmail.com wrote:

> From: MengEn Sun <mengensun@tencent.com>
> 
> NUMA events will only be folded from per-CPU statistics to per
> zone and global statistics when the user actually needs it.
> 
> So, we perform this folding when reading the /proc/zoneinfo

When proposing a fix, please always fully describe the
userspace-visible effects of that fix.

> Fixes: f19298b9516c ("mm/vmstat: convert NUMA statistics to basic NUMA counters")

Since v5.14.

The information which I requested will help others decide whether
earlier kernel versions should apply this fix.