[v4] Fix unmasking interrupt bit and remove watermark interrupt enablement

[PATCH v4 0/2] Fix unmasking interrupt bit and remove watermark interrupt enablement

Posted by Mrinmay Sarkar 3 weeks ago

This patch series reset STOP_INT_MASK and ABORT_INT_MASK bit and unmask
these interrupt for HDMA.

and also remove enablement of local watermark interrupt enable(LWIE)
and remote watermarek interrupt enable(RWIE) bit to avoid unnecessary
watermark interrupt event.

Testing
-------

Tested on Qualcomm SA8775P Platform.

V3 -> V4:
- convert IRQs unmasking in a clearer way as suggested by Serge.

V2 -> V3:
- convert 'STOP, ABORT' to 'stop, abort' as suggested by Serge
- Added Reviewed-by tag

V1 -> V2:
- Modified commit message and added Fixes, CC tag as suggested by Mani
- reanme done to STOP
- rename DW_HDMA_V0_LIE -> DW_HDMA_V0_LWIE and DW_HDMA_V0_RIE -> DW_HDMA_V0_RWIE

Mrinmay Sarkar (2):
  dmaengine: dw-edma: Fix unmasking STOP and ABORT interrupts for HDMA
  dmaengine: dw-edma: Do not enable watermark interrupts for HDMA

 drivers/dma/dw-edma/dw-hdma-v0-core.c | 26 ++++++++------------------
 1 file changed, 8 insertions(+), 18 deletions(-)

-- 
2.7.4

Re: [PATCH v4 0/2] Fix unmasking interrupt bit and remove watermark interrupt enablement

Posted by Serge Semin 2 weeks, 4 days ago

On Mon, Aug 26, 2024 at 05:40:59PM +0530, Mrinmay Sarkar wrote:
> This patch series reset STOP_INT_MASK and ABORT_INT_MASK bit and unmask
> these interrupt for HDMA.
> 
> and also remove enablement of local watermark interrupt enable(LWIE)
> and remote watermarek interrupt enable(RWIE) bit to avoid unnecessary
> watermark interrupt event.
> 
> Testing
> -------
> 
> Tested on Qualcomm SA8775P Platform.
> 
> V3 -> V4:
> - convert IRQs unmasking in a clearer way as suggested by Serge.

Thanks for submitting the update. The patches have already been merged
in, but anyway here is my tag:

Reviewed-by: Serge Semin <fancer.lancer@gmail.com>

-Serge(y)

> 
> V2 -> V3:
> - convert 'STOP, ABORT' to 'stop, abort' as suggested by Serge
> - Added Reviewed-by tag
> 
> V1 -> V2:
> - Modified commit message and added Fixes, CC tag as suggested by Mani
> - reanme done to STOP
> - rename DW_HDMA_V0_LIE -> DW_HDMA_V0_LWIE and DW_HDMA_V0_RIE -> DW_HDMA_V0_RWIE
> 
> Mrinmay Sarkar (2):
>   dmaengine: dw-edma: Fix unmasking STOP and ABORT interrupts for HDMA
>   dmaengine: dw-edma: Do not enable watermark interrupts for HDMA
> 
>  drivers/dma/dw-edma/dw-hdma-v0-core.c | 26 ++++++++------------------
>  1 file changed, 8 insertions(+), 18 deletions(-)
> 
> -- 
> 2.7.4
>

Re: [PATCH v4 0/2] Fix unmasking interrupt bit and remove watermark interrupt enablement

Posted by Vinod Koul 2 weeks, 5 days ago

On Mon, 26 Aug 2024 17:40:59 +0530, Mrinmay Sarkar wrote:
> This patch series reset STOP_INT_MASK and ABORT_INT_MASK bit and unmask
> these interrupt for HDMA.
> 
> and also remove enablement of local watermark interrupt enable(LWIE)
> and remote watermarek interrupt enable(RWIE) bit to avoid unnecessary
> watermark interrupt event.
> 
> [...]

Applied, thanks!

[1/2] dmaengine: dw-edma: Fix unmasking STOP and ABORT interrupts for HDMA
      commit: 383baf5c8f062091af34c63f28d37642a8f188ae
[2/2] dmaengine: dw-edma: Do not enable watermark interrupts for HDMA
      commit: 9f646ff25c09c52cebe726601db27a60f876f15e

Best regards,
-- 
~Vinod