[v1] arm64: dts: imx93-11x11-evk: Add several sound cards

[PATCH 0/3] arm64: dts: imx93-11x11-evk: Add several sound cards

Posted by Shengjiu Wang 1 year, 4 months ago

Add bt-sco, PDM microphone, XCVR sound card support.

Shengjiu Wang (3):
  arm64: dts: imx93-11x11-evk: add bt-sco sound card support
  arm64: dts: imx93-11x11-evk: Add PDM microphone sound card support
  arm64: dts: imx93-11x11-evk: Add audio XCVR sound card

 .../boot/dts/freescale/imx93-11x11-evk.dts    | 135 ++++++++++++++++++
 1 file changed, 135 insertions(+)

-- 
2.34.1

Re: [PATCH 0/3] arm64: dts: imx93-11x11-evk: Add several sound cards

Posted by Rob Herring (Arm) 1 year, 4 months ago

On Thu, 25 Jul 2024 16:59:05 +0800, Shengjiu Wang wrote:
> Add bt-sco, PDM microphone, XCVR sound card support.
> 
> Shengjiu Wang (3):
>   arm64: dts: imx93-11x11-evk: add bt-sco sound card support
>   arm64: dts: imx93-11x11-evk: Add PDM microphone sound card support
>   arm64: dts: imx93-11x11-evk: Add audio XCVR sound card
> 
>  .../boot/dts/freescale/imx93-11x11-evk.dts    | 135 ++++++++++++++++++
>  1 file changed, 135 insertions(+)
> 
> --
> 2.34.1
> 
> 
> 

My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

New warnings running 'make CHECK_DTBS=y freescale/imx93-11x11-evk.dtb' for 1721897948-6306-1-git-send-email-shengjiu.wang@nxp.com:

arch/arm64/boot/dts/freescale/imx93-11x11-evk.dtb: pinctrl@443c0000: 'pdmgrpsleep', 'sai1grpsleep', 'spdifgrpsleep' do not match any of the regexes: 'grp$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/pinctrl/fsl,imx9-pinctrl.yaml#

Re: [PATCH 0/3] arm64: dts: imx93-11x11-evk: Add several sound cards

Posted by Krzysztof Kozlowski 1 year, 4 months ago

On 26/07/2024 00:20, Rob Herring (Arm) wrote:
> 
> On Thu, 25 Jul 2024 16:59:05 +0800, Shengjiu Wang wrote:
>> Add bt-sco, PDM microphone, XCVR sound card support.
>>
>> Shengjiu Wang (3):
>>   arm64: dts: imx93-11x11-evk: add bt-sco sound card support
>>   arm64: dts: imx93-11x11-evk: Add PDM microphone sound card support
>>   arm64: dts: imx93-11x11-evk: Add audio XCVR sound card
>>
>>  .../boot/dts/freescale/imx93-11x11-evk.dts    | 135 ++++++++++++++++++
>>  1 file changed, 135 insertions(+)
>>
>> --
>> 2.34.1
>>
>>
>>
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> New warnings running 'make CHECK_DTBS=y freescale/imx93-11x11-evk.dtb' for 1721897948-6306-1-git-send-email-shengjiu.wang@nxp.com:
> 
> arch/arm64/boot/dts/freescale/imx93-11x11-evk.dtb: pinctrl@443c0000: 'pdmgrpsleep', 'sai1grpsleep', 'spdifgrpsleep' do not match any of the regexes: 'grp$', 'pinctrl-[0-9]+'

And that's a proof that you did not test it.

Is anyone in NXP testing patches before sending?

Best regards,
Krzysztof