[v3] Add dbi2 and atu for i.MX8M PCIe EP

[PATCH v3 0/4] Add dbi2 and atu for i.MX8M PCIe EP

Posted by Richard Zhu 1 year, 4 months ago

v3 changes:
- Refine the commit descriptions.

v2 changes:
Thanks for Conor's comments.
- Place the new added properties at the end.

Ideally, dbi2 and atu base addresses should be fetched from DT.
Add dbi2 and atu base addresses for i.MX8M PCIe EP here.

[PATCH v3 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu"
[PATCH v3 2/4] dts: arm64: imx8mq: Add dbi2 and atu reg for i.MX8MQ
[PATCH v3 3/4] dts: arm64: imx8mp: Add dbi2 and atu reg for i.MX8MP
[PATCH v3 4/4] dts: arm64: imx8mm: Add dbi2 and atu reg for i.MX8MM

Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml | 13 +++++++++----
arch/arm64/boot/dts/freescale/imx8mm.dtsi                    |  8 +++++---
arch/arm64/boot/dts/freescale/imx8mp.dtsi                    |  7 +++++--
arch/arm64/boot/dts/freescale/imx8mq.dtsi                    |  8 +++++---
4 files changed, 24 insertions(+), 12 deletions(-)

Re: [PATCH v3 0/4] Add dbi2 and atu for i.MX8M PCIe EP

Posted by Bjorn Helgaas 1 year, 4 months ago

On Thu, Jul 25, 2024 at 03:35:12PM +0800, Richard Zhu wrote:
> v3 changes:
> - Refine the commit descriptions.
> 
> v2 changes:
> Thanks for Conor's comments.
> - Place the new added properties at the end.
> 
> Ideally, dbi2 and atu base addresses should be fetched from DT.
> Add dbi2 and atu base addresses for i.MX8M PCIe EP here.
> 
> [PATCH v3 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu"
> [PATCH v3 2/4] dts: arm64: imx8mq: Add dbi2 and atu reg for i.MX8MQ
> [PATCH v3 3/4] dts: arm64: imx8mp: Add dbi2 and atu reg for i.MX8MP
> [PATCH v3 4/4] dts: arm64: imx8mm: Add dbi2 and atu reg for i.MX8MM
> 
> Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml | 13 +++++++++----
> arch/arm64/boot/dts/freescale/imx8mm.dtsi                    |  8 +++++---
> arch/arm64/boot/dts/freescale/imx8mp.dtsi                    |  7 +++++--
> arch/arm64/boot/dts/freescale/imx8mq.dtsi                    |  8 +++++---
> 4 files changed, 24 insertions(+), 12 deletions(-)

For all the patches in this series, can you please:

  - Separate paragraphs with blank lines so we know where they end.

  - Wrap commit log to fill 75 columns.

Re: [PATCH v3 0/4] Add dbi2 and atu for i.MX8M PCIe EP

Posted by Frank Li 1 year, 4 months ago

On Thu, Jul 25, 2024 at 03:35:12PM +0800, Richard Zhu wrote:
> v3 changes:
> - Refine the commit descriptions.
> 
> v2 changes:
> Thanks for Conor's comments.
> - Place the new added properties at the end.
> 
> Ideally, dbi2 and atu base addresses should be fetched from DT.
> Add dbi2 and atu base addresses for i.MX8M PCIe EP here.
> 
> [PATCH v3 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu"
> [PATCH v3 2/4] dts: arm64: imx8mq: Add dbi2 and atu reg for i.MX8MQ
> [PATCH v3 3/4] dts: arm64: imx8mp: Add dbi2 and atu reg for i.MX8MP
> [PATCH v3 4/4] dts: arm64: imx8mm: Add dbi2 and atu reg for i.MX8MM

for all patches:

Reviewed-by: Frank Li <Frank.Li@nxp.com>
> 
> Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml | 13 +++++++++----
> arch/arm64/boot/dts/freescale/imx8mm.dtsi                    |  8 +++++---
> arch/arm64/boot/dts/freescale/imx8mp.dtsi                    |  7 +++++--
> arch/arm64/boot/dts/freescale/imx8mq.dtsi                    |  8 +++++---
> 4 files changed, 24 insertions(+), 12 deletions(-)