f2fs: fix to remove redundant SBI_NEED_FSCK flag set

[PATCH] f2fs: fix to remove redundant SBI_NEED_FSCK flag set

Posted by Zhiguo Niu 2 years, 1 month ago

Subsequent f2fs_stop_checkpoint will set cp_err, so this
SBI_NEED_FSCK flag set action is invalid.

Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
---
 fs/f2fs/gc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index 20e2f98..ef667fe 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -1752,7 +1752,6 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi,
 		if (type != GET_SUM_TYPE((&sum->footer))) {
 			f2fs_err(sbi, "Inconsistent segment (%u) type [%d, %d] in SSA and SIT",
 				 segno, type, GET_SUM_TYPE((&sum->footer)));
-			set_sbi_flag(sbi, SBI_NEED_FSCK);
 			f2fs_stop_checkpoint(sbi, false,
 				STOP_CP_REASON_CORRUPTED_SUMMARY);
 			goto skip;
-- 
1.9.1

Re: [PATCH] f2fs: fix to remove redundant SBI_NEED_FSCK flag set

Posted by Chao Yu 2 years, 1 month ago

On 2024/5/27 19:12, Zhiguo Niu wrote:
> Subsequent f2fs_stop_checkpoint will set cp_err, so this
> SBI_NEED_FSCK flag set action is invalid.
> 
> Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,