usb: dwc2: Disable clock gating feature on Rockchip SoCs

[PATCH] usb: dwc2: Disable clock gating feature on Rockchip SoCs

Posted by William Wu 2 years ago

The DWC2 IP on the Rockchip SoCs doesn't support clock gating.
When a clock gating is enabled, system hangs.

Signed-off-by: William Wu <william.wu@rock-chips.com>
---
 drivers/usb/dwc2/params.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index fb03162..eb677c3 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -130,6 +130,7 @@ static void dwc2_set_rk_params(struct dwc2_hsotg *hsotg)
 	p->lpm_clock_gating = false;
 	p->besl = false;
 	p->hird_threshold_en = false;
+	p->no_clock_gating = true;
 }
 
 static void dwc2_set_ltq_params(struct dwc2_hsotg *hsotg)
-- 
2.0.0

Re: [PATCH] usb: dwc2: Disable clock gating feature on Rockchip SoCs

Posted by Minas Harutyunyan 2 years ago

Hi,

On 12/26/23 11:19, William Wu wrote:
> The DWC2 IP on the Rockchip SoCs doesn't support clock gating.
> When a clock gating is enabled, system hangs.
> 
> Signed-off-by: William Wu <william.wu@rock-chips.com>

Acked-by: Minas Harutyunyan <hminas@synopsys.com>

> ---
>   drivers/usb/dwc2/params.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index fb03162..eb677c3 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -130,6 +130,7 @@ static void dwc2_set_rk_params(struct dwc2_hsotg *hsotg)
>   	p->lpm_clock_gating = false;
>   	p->besl = false;
>   	p->hird_threshold_en = false;
> +	p->no_clock_gating = true;
>   }
>   
>   static void dwc2_set_ltq_params(struct dwc2_hsotg *hsotg)