[v4] Register with RDMA SOC interface and support for CQ

[Patch v4 0/3] Register with RDMA SOC interface and support for CQ

Posted by longli@linuxonhyperv.com 2 years ago

From: Long Li <longli@microsoft.com>

This patchset add support for registering a RDMA device with SoC for
support of querying device capabilities, upcoming RC queue pairs and
CQ interrupts.

This patchset is partially based on Ajay Sharma's work:
https://lore.kernel.org/netdev/1697494322-26814-1-git-send-email-sharmaajay@linuxonhyperv.com

Changes in v2:
Dropped the patches to create EQs for RC QP. They will be implemented with
RC patches.


Long Li (3):
  RDMA/mana_ib: register RDMA device with GDMA
  RDMA/mana_ib: query device capabilities
  RDMA/mana_ib: Add CQ interrupt support for RAW QP

 drivers/infiniband/hw/mana/cq.c               | 34 ++++++-
 drivers/infiniband/hw/mana/device.c           | 31 +++++--
 drivers/infiniband/hw/mana/main.c             | 69 ++++++++++----
 drivers/infiniband/hw/mana/mana_ib.h          | 53 +++++++++++
 drivers/infiniband/hw/mana/qp.c               | 90 ++++++++++++++++---
 .../net/ethernet/microsoft/mana/gdma_main.c   |  5 ++
 include/net/mana/gdma.h                       |  5 ++
 7 files changed, 252 insertions(+), 35 deletions(-)

-- 
2.25.1

Re: [Patch v4 0/3] Register with RDMA SOC interface and support for CQ

Posted by Leon Romanovsky 2 years ago

On Fri, Dec 15, 2023 at 06:04:12PM -0800, longli@linuxonhyperv.com wrote:
> From: Long Li <longli@microsoft.com>
> 
> This patchset add support for registering a RDMA device with SoC for
> support of querying device capabilities, upcoming RC queue pairs and
> CQ interrupts.
> 
> This patchset is partially based on Ajay Sharma's work:
> https://lore.kernel.org/netdev/1697494322-26814-1-git-send-email-sharmaajay@linuxonhyperv.com
> 
> Changes in v2:
> Dropped the patches to create EQs for RC QP. They will be implemented with
> RC patches.
> 
> 
> Long Li (3):
>   RDMA/mana_ib: register RDMA device with GDMA
>   RDMA/mana_ib: query device capabilities
>   RDMA/mana_ib: Add CQ interrupt support for RAW QP
> 
>  drivers/infiniband/hw/mana/cq.c               | 34 ++++++-
>  drivers/infiniband/hw/mana/device.c           | 31 +++++--
>  drivers/infiniband/hw/mana/main.c             | 69 ++++++++++----
>  drivers/infiniband/hw/mana/mana_ib.h          | 53 +++++++++++
>  drivers/infiniband/hw/mana/qp.c               | 90 ++++++++++++++++---
>  .../net/ethernet/microsoft/mana/gdma_main.c   |  5 ++
>  include/net/mana/gdma.h                       |  5 ++
>  7 files changed, 252 insertions(+), 35 deletions(-)

Applied with the following change in third patch.

diff --git a/drivers/infiniband/hw/mana/qp.c b/drivers/infiniband/hw/mana/qp.c
index 19998082a376..21ac9fcadf3f 100644
--- a/drivers/infiniband/hw/mana/qp.c
+++ b/drivers/infiniband/hw/mana/qp.c
@@ -443,17 +443,16 @@ static int mana_ib_create_qp_raw(struct ib_qp *ibqp, struct ib_pd *ibpd,
                ibdev_dbg(&mdev->ib_dev,
                          "Failed copy udata for create qp-raw, %d\n",
                          err);
-               goto err_destroy_wq_obj;
+               goto err_release_gdma_cq;
        }

        return 0;

-err_destroy_wq_obj:
-       if (gdma_cq) {
-               kfree(gdma_cq);
-               gd->gdma_context->cq_table[send_cq->id] = NULL;
-       }
+err_release_gdma_cq:
+       kfree(gdma_cq);
+       gd->gdma_context->cq_table[send_cq->id] = NULL;

+err_destroy_wq_obj:
        mana_destroy_wq_obj(mpc, GDMA_SQ, qp->tx_object);

 err_destroy_dma_region:


> 
> -- 
> 2.25.1
>

Re: [Patch v4 0/3] Register with RDMA SOC interface and support for CQ

Posted by Leon Romanovsky 2 years ago

On Fri, Dec 15, 2023 at 06:04:12PM -0800, longli@linuxonhyperv.com wrote:
> From: Long Li <longli@microsoft.com>
> 
> This patchset add support for registering a RDMA device with SoC for
> support of querying device capabilities, upcoming RC queue pairs and
> CQ interrupts.
> 
> This patchset is partially based on Ajay Sharma's work:
> https://lore.kernel.org/netdev/1697494322-26814-1-git-send-email-sharmaajay@linuxonhyperv.com
> 
> Changes in v2:
> Dropped the patches to create EQs for RC QP. They will be implemented with
> RC patches.

You sent twice v2, never sent v3 and two days later sent v4 without even
explaining why.

Can you please invest time and write more detailed changelog which will
include v2, v3 and v4 changes?

Tanks

> 
> 
> Long Li (3):
>   RDMA/mana_ib: register RDMA device with GDMA
>   RDMA/mana_ib: query device capabilities
>   RDMA/mana_ib: Add CQ interrupt support for RAW QP
> 
>  drivers/infiniband/hw/mana/cq.c               | 34 ++++++-
>  drivers/infiniband/hw/mana/device.c           | 31 +++++--
>  drivers/infiniband/hw/mana/main.c             | 69 ++++++++++----
>  drivers/infiniband/hw/mana/mana_ib.h          | 53 +++++++++++
>  drivers/infiniband/hw/mana/qp.c               | 90 ++++++++++++++++---
>  .../net/ethernet/microsoft/mana/gdma_main.c   |  5 ++
>  include/net/mana/gdma.h                       |  5 ++
>  7 files changed, 252 insertions(+), 35 deletions(-)
> 
> -- 
> 2.25.1
>

Re: [Patch v4 0/3] Register with RDMA SOC interface and support for CQ

Posted by Leon Romanovsky 2 years ago

On Fri, 15 Dec 2023 18:04:12 -0800, longli@linuxonhyperv.com wrote:
> From: Long Li <longli@microsoft.com>
> 
> This patchset add support for registering a RDMA device with SoC for
> support of querying device capabilities, upcoming RC queue pairs and
> CQ interrupts.
> 
> This patchset is partially based on Ajay Sharma's work:
> https://lore.kernel.org/netdev/1697494322-26814-1-git-send-email-sharmaajay@linuxonhyperv.com
> 
> [...]

Applied, thanks!

[1/3] RDMA/mana_ib: register RDMA device with GDMA
      https://git.kernel.org/rdma/rdma/c/a7f0636d223ca9
[2/3] RDMA/mana_ib: query device capabilities
      https://git.kernel.org/rdma/rdma/c/2c20e20b22d9fc
[3/3] RDMA/mana_ib: Add CQ interrupt support for RAW QP
      https://git.kernel.org/rdma/rdma/c/c15d7802a42402

Best regards,
-- 
Leon Romanovsky <leon@kernel.org>