[PATCH net-next v2 0/7] net/smc: implement SMCv2.1 virtual ISM device support

Wen Gu posted 7 patches 2 years ago
There is a newer version of this series
drivers/s390/net/ism.h     |  6 ---
drivers/s390/net/ism_drv.c | 54 +++++++--------------------
include/linux/ism.h        |  1 -
include/net/smc.h          | 16 +++++---
net/smc/af_smc.c           | 68 ++++++++++++++++++++++++++-------
net/smc/smc.h              |  7 ++++
net/smc/smc_clc.c          | 93 ++++++++++++++++++++++++++++++++--------------
net/smc/smc_clc.h          | 22 +++++++----
net/smc/smc_core.c         | 32 ++++++++++------
net/smc/smc_core.h         |  8 ++--
net/smc/smc_diag.c         |  7 +++-
net/smc/smc_ism.c          | 57 ++++++++++++++++++++--------
net/smc/smc_ism.h          | 31 +++++++++++++++-
net/smc/smc_pnet.c         |  4 +-
14 files changed, 270 insertions(+), 136 deletions(-)
[PATCH net-next v2 0/7] net/smc: implement SMCv2.1 virtual ISM device support
Posted by Wen Gu 2 years ago
The fourth edition of SMCv2 adds the SMC version 2.1 feature updates for
SMC-Dv2 with virtual ISM. Virtual ISM are created and supported mainly by
OS or hypervisor software, comparable to IBM ISM which is based on platform
firmware or hardware.

With the introduction of virtual ISM, SMCv2.1 makes some updates:

- Introduce feature bitmask to indicate supplemental features.
- Reserve a range of CHIDs for virtual ISM.
- Support extended GIDs (128 bits) in CLC handshake.

So this patch set aims to implement these updates in Linux kernel. And it
acts as the first part of SMC-D virtual ISM extension & loopback-ism [1].

[1] https://lore.kernel.org/netdev/1695568613-125057-1-git-send-email-guwen@linux.alibaba.com/

v2->v1:
- Fix sparse complaint;
- Rebase to the latest net-next;

Wen Gu (7):
  net/smc: Rename some variable 'fce' to 'fce_v2x' for clarity
  net/smc: support SMCv2.x supplemental features negotiation
  net/smc: introduce virtual ISM device support feature
  net/smc: define a reserved CHID range for virtual ISM devices
  net/smc: compatible with 128-bits extend GID of virtual ISM device
  net/smc: disable SEID on non-s390 archs where virtual ISM may be used
  net/smc: manage system EID in SMC stack instead of ISM driver

 drivers/s390/net/ism.h     |  6 ---
 drivers/s390/net/ism_drv.c | 54 +++++++--------------------
 include/linux/ism.h        |  1 -
 include/net/smc.h          | 16 +++++---
 net/smc/af_smc.c           | 68 ++++++++++++++++++++++++++-------
 net/smc/smc.h              |  7 ++++
 net/smc/smc_clc.c          | 93 ++++++++++++++++++++++++++++++++--------------
 net/smc/smc_clc.h          | 22 +++++++----
 net/smc/smc_core.c         | 32 ++++++++++------
 net/smc/smc_core.h         |  8 ++--
 net/smc/smc_diag.c         |  7 +++-
 net/smc/smc_ism.c          | 57 ++++++++++++++++++++--------
 net/smc/smc_ism.h          | 31 +++++++++++++++-
 net/smc/smc_pnet.c         |  4 +-
 14 files changed, 270 insertions(+), 136 deletions(-)

-- 
1.8.3.1
Re: [PATCH net-next v2 0/7] net/smc: implement SMCv2.1 virtual ISM device support
Posted by Wenjia Zhang 2 years ago

On 24.11.23 15:42, Wen Gu wrote:
> The fourth edition of SMCv2 adds the SMC version 2.1 feature updates for
> SMC-Dv2 with virtual ISM. Virtual ISM are created and supported mainly by
> OS or hypervisor software, comparable to IBM ISM which is based on platform
> firmware or hardware.
> 
> With the introduction of virtual ISM, SMCv2.1 makes some updates:
> 
> - Introduce feature bitmask to indicate supplemental features.
> - Reserve a range of CHIDs for virtual ISM.
> - Support extended GIDs (128 bits) in CLC handshake.
> 
> So this patch set aims to implement these updates in Linux kernel. And it
> acts as the first part of SMC-D virtual ISM extension & loopback-ism [1].
> 
> [1] https://lore.kernel.org/netdev/1695568613-125057-1-git-send-email-guwen@linux.alibaba.com/
> 
> v2->v1:
> - Fix sparse complaint;
> - Rebase to the latest net-next;
> 

It looks good to me. The testing looks good as well.
If these comments are worked out, I'd like to give my Reviewed-by for 
the next version.
BTW, for the next version, you need to rebase your kernel.