Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 4 ++++ 1 file changed, 4 insertions(+)
Document the description for the qcom,esi-affinity-mask.
Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com>
---
Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
index bdfa86a..323595f 100644
--- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
@@ -97,6 +97,10 @@ properties:
description:
GPIO connected to the RESET pin of the UFS memory device.
+ qcom,esi-affinity-mask:
+ description:
+ UFS MCQ ESI affinity mask. Affine ESI on registration according to this CPU mask.
+
required:
- compatible
- reg
--
2.7.4Hi Ziqi,
kernel test robot noticed the following build warnings:
[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v6.6-rc3 next-20230926]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Ziqi-Chen/scsi-ufs-qcom-dt-bindings-Add-MCQ-ESI-property/20230908-165641
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/1694163203-39123-1-git-send-email-quic_ziqichen%40quicinc.com
patch subject: [PATCH] scsi: ufs: qcom: dt-bindings: Add MCQ ESI property
:::::: branch date: 3 weeks ago
:::::: commit date: 3 weeks ago
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230927/202309270236.73iDpbX8-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202309270236.73iDpbX8-lkp@intel.com/
dtcheck warnings: (new ones prefixed by >>)
>> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml:108:8: [warning] wrong indentation: expected 6 but found 7 (indentation)
--
Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml: properties:adi,ext1-burnout-current-nanoamp: '$ref' should not be valid under {'const': '$ref'}
hint: Standard unit suffix properties don't need a type $ref
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml: properties:adi,ext2-burnout-current-nanoamp: '$ref' should not be valid under {'const': '$ref'}
hint: Standard unit suffix properties don't need a type $ref
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml: properties:adi,viout-burnout-current-nanoamp: '$ref' should not be valid under {'const': '$ref'}
hint: Standard unit suffix properties don't need a type $ref
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
>> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml: properties:qcom,esi-affinity-mask: 'oneOf' conditional failed, one must be fixed:
'type' is a required property
hint: A vendor boolean property can use "type: boolean"
>> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml: properties:qcom,esi-affinity-mask: 'oneOf' conditional failed, one must be fixed:
'enum' is a required property
'const' is a required property
hint: A vendor string property with exact values has an implicit type
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml: properties:qcom,esi-affinity-mask: 'oneOf' conditional failed, one must be fixed:
'$ref' is a required property
'allOf' is a required property
hint: A vendor property needs a $ref to types.yaml
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
vim +108 Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 8
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 9 maintainers:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 10 - Bjorn Andersson <bjorn.andersson@linaro.org>
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 11 - Andy Gross <agross@kernel.org>
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 12
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 13 # Select only our matches, not all jedec,ufs-2.0
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 14 select:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 15 properties:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 16 compatible:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 17 contains:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 18 const: qcom,ufshc
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 19 required:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 20 - compatible
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 21
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 22 properties:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 23 compatible:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 24 items:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 25 - enum:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 26 - qcom,msm8994-ufshc
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 27 - qcom,msm8996-ufshc
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 28 - qcom,msm8998-ufshc
8f0c17bf6bf33b Bartosz Golaszewski 2023-04-11 29 - qcom,sa8775p-ufshc
2f3b3200ac389d Johan Hovold 2022-07-11 30 - qcom,sc8280xp-ufshc
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 31 - qcom,sdm845-ufshc
a11eaed308efc7 Iskren Chernev 2023-08-14 32 - qcom,sm6115-ufshc
3d8fa7a22dcd54 Luca Weiss 2022-03-21 33 - qcom,sm6350-ufshc
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 34 - qcom,sm8150-ufshc
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 35 - qcom,sm8250-ufshc
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 36 - qcom,sm8350-ufshc
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 37 - qcom,sm8450-ufshc
b8c203891121be Abel Vesa 2023-01-19 38 - qcom,sm8550-ufshc
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 39 - const: qcom,ufshc
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 40 - const: jedec,ufs-2.0
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 41
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 42 clocks:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 43 minItems: 8
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 44 maxItems: 11
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 45
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 46 clock-names:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 47 minItems: 8
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 48 maxItems: 11
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 49
85e182b48a33a4 Johan Hovold 2023-01-16 50 dma-coherent: true
85e182b48a33a4 Johan Hovold 2023-01-16 51
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 52 interconnects:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 53 minItems: 2
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 54 maxItems: 2
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 55
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 56 interconnect-names:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 57 items:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 58 - const: ufs-ddr
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 59 - const: cpu-ufs
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 60
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 61 iommus:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 62 minItems: 1
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 63 maxItems: 2
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 64
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 65 phys:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 66 maxItems: 1
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 67
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 68 phy-names:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 69 items:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 70 - const: ufsphy
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 71
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 72 power-domains:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 73 maxItems: 1
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 74
29a6d1215b7cd5 Abel Vesa 2023-06-12 75 qcom,ice:
29a6d1215b7cd5 Abel Vesa 2023-06-12 76 $ref: /schemas/types.yaml#/definitions/phandle
29a6d1215b7cd5 Abel Vesa 2023-06-12 77 description: phandle to the Inline Crypto Engine node
29a6d1215b7cd5 Abel Vesa 2023-06-12 78
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 79 reg:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 80 minItems: 1
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 81 maxItems: 2
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 82
7839d566c653bc Luca Weiss 2023-08-14 83 reg-names:
7839d566c653bc Luca Weiss 2023-08-14 84 items:
7839d566c653bc Luca Weiss 2023-08-14 85 - const: std
7839d566c653bc Luca Weiss 2023-08-14 86 - const: ice
7839d566c653bc Luca Weiss 2023-08-14 87
8ffbaa98ccf823 Krzysztof Kozlowski 2022-12-28 88 required-opps:
8ffbaa98ccf823 Krzysztof Kozlowski 2022-12-28 89 maxItems: 1
8ffbaa98ccf823 Krzysztof Kozlowski 2022-12-28 90
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 91 resets:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 92 maxItems: 1
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 93
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 94 '#reset-cells':
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 95 const: 1
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 96
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 97 reset-names:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 98 items:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 99 - const: rst
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 100
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 101 reset-gpios:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 102 maxItems: 1
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 103 description:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 104 GPIO connected to the RESET pin of the UFS memory device.
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 105
b620cbe2435f88 Ziqi Chen 2023-09-08 106 qcom,esi-affinity-mask:
b620cbe2435f88 Ziqi Chen 2023-09-08 107 description:
b620cbe2435f88 Ziqi Chen 2023-09-08 @108 UFS MCQ ESI affinity mask. Affine ESI on registration according to this CPU mask.
b620cbe2435f88 Ziqi Chen 2023-09-08 109
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 110 required:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 111 - compatible
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 112 - reg
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 113
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 114 allOf:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 115 - $ref: ufs-common.yaml
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 116
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 117 - if:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 118 properties:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 119 compatible:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 120 contains:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 121 enum:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 122 - qcom,msm8998-ufshc
8f0c17bf6bf33b Bartosz Golaszewski 2023-04-11 123 - qcom,sa8775p-ufshc
2f3b3200ac389d Johan Hovold 2022-07-11 124 - qcom,sc8280xp-ufshc
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 125 - qcom,sm8250-ufshc
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 126 - qcom,sm8350-ufshc
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 127 - qcom,sm8450-ufshc
b8c203891121be Abel Vesa 2023-01-19 128 - qcom,sm8550-ufshc
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 129 then:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 130 properties:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 131 clocks:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 132 minItems: 8
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 133 maxItems: 8
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 134 clock-names:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 135 items:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 136 - const: core_clk
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 137 - const: bus_aggr_clk
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 138 - const: iface_clk
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 139 - const: core_clk_unipro
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 140 - const: ref_clk
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 141 - const: tx_lane0_sync_clk
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 142 - const: rx_lane0_sync_clk
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 143 - const: rx_lane1_sync_clk
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 144 reg:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 145 minItems: 1
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 146 maxItems: 1
7839d566c653bc Luca Weiss 2023-08-14 147 reg-names:
7839d566c653bc Luca Weiss 2023-08-14 148 maxItems: 1
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 149
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 150 - if:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 151 properties:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 152 compatible:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 153 contains:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 154 enum:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 155 - qcom,sdm845-ufshc
3d8fa7a22dcd54 Luca Weiss 2022-03-21 156 - qcom,sm6350-ufshc
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 157 - qcom,sm8150-ufshc
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 158 then:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 159 properties:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 160 clocks:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 161 minItems: 9
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 162 maxItems: 9
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 163 clock-names:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 164 items:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 165 - const: core_clk
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 166 - const: bus_aggr_clk
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 167 - const: iface_clk
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 168 - const: core_clk_unipro
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 169 - const: ref_clk
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 170 - const: tx_lane0_sync_clk
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 171 - const: rx_lane0_sync_clk
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 172 - const: rx_lane1_sync_clk
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 173 - const: ice_core_clk
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 174 reg:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 175 minItems: 2
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 176 maxItems: 2
7839d566c653bc Luca Weiss 2023-08-14 177 reg-names:
7839d566c653bc Luca Weiss 2023-08-14 178 minItems: 2
7839d566c653bc Luca Weiss 2023-08-14 179 required:
7839d566c653bc Luca Weiss 2023-08-14 180 - reg-names
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 181
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 182 - if:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 183 properties:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 184 compatible:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 185 contains:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 186 enum:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 187 - qcom,msm8996-ufshc
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 188 then:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 189 properties:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 190 clocks:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 191 minItems: 11
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 192 maxItems: 11
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 193 clock-names:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 194 items:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 195 - const: core_clk_src
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 196 - const: core_clk
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 197 - const: bus_clk
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 198 - const: bus_aggr_clk
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 199 - const: iface_clk
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 200 - const: core_clk_unipro_src
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 201 - const: core_clk_unipro
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 202 - const: core_clk_ice
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 203 - const: ref_clk
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 204 - const: tx_lane0_sync_clk
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 205 - const: rx_lane0_sync_clk
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 206 reg:
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 207 minItems: 1
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 208 maxItems: 1
7839d566c653bc Luca Weiss 2023-08-14 209 reg-names:
7839d566c653bc Luca Weiss 2023-08-14 210 maxItems: 1
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 211
a11eaed308efc7 Iskren Chernev 2023-08-14 212 - if:
a11eaed308efc7 Iskren Chernev 2023-08-14 213 properties:
a11eaed308efc7 Iskren Chernev 2023-08-14 214 compatible:
a11eaed308efc7 Iskren Chernev 2023-08-14 215 contains:
a11eaed308efc7 Iskren Chernev 2023-08-14 216 enum:
a11eaed308efc7 Iskren Chernev 2023-08-14 217 - qcom,sm6115-ufshc
a11eaed308efc7 Iskren Chernev 2023-08-14 218 then:
a11eaed308efc7 Iskren Chernev 2023-08-14 219 properties:
a11eaed308efc7 Iskren Chernev 2023-08-14 220 clocks:
a11eaed308efc7 Iskren Chernev 2023-08-14 221 minItems: 8
a11eaed308efc7 Iskren Chernev 2023-08-14 222 maxItems: 8
a11eaed308efc7 Iskren Chernev 2023-08-14 223 clock-names:
a11eaed308efc7 Iskren Chernev 2023-08-14 224 items:
a11eaed308efc7 Iskren Chernev 2023-08-14 225 - const: core_clk
a11eaed308efc7 Iskren Chernev 2023-08-14 226 - const: bus_aggr_clk
a11eaed308efc7 Iskren Chernev 2023-08-14 227 - const: iface_clk
a11eaed308efc7 Iskren Chernev 2023-08-14 228 - const: core_clk_unipro
a11eaed308efc7 Iskren Chernev 2023-08-14 229 - const: ref_clk
a11eaed308efc7 Iskren Chernev 2023-08-14 230 - const: tx_lane0_sync_clk
a11eaed308efc7 Iskren Chernev 2023-08-14 231 - const: rx_lane0_sync_clk
a11eaed308efc7 Iskren Chernev 2023-08-14 232 - const: ice_core_clk
a11eaed308efc7 Iskren Chernev 2023-08-14 233 reg:
a11eaed308efc7 Iskren Chernev 2023-08-14 234 minItems: 2
a11eaed308efc7 Iskren Chernev 2023-08-14 235 maxItems: 2
a11eaed308efc7 Iskren Chernev 2023-08-14 236 reg-names:
a11eaed308efc7 Iskren Chernev 2023-08-14 237 minItems: 2
a11eaed308efc7 Iskren Chernev 2023-08-14 238 required:
a11eaed308efc7 Iskren Chernev 2023-08-14 239 - reg-names
a11eaed308efc7 Iskren Chernev 2023-08-14 240
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 241 # TODO: define clock bindings for qcom,msm8994-ufshc
462c5c0aa7989e Krzysztof Kozlowski 2022-03-06 242
29a6d1215b7cd5 Abel Vesa 2023-06-12 243 - if:
9b7c13b83c1ded Abel Vesa 2023-06-23 244 required:
9b7c13b83c1ded Abel Vesa 2023-06-23 245 - qcom,ice
29a6d1215b7cd5 Abel Vesa 2023-06-12 246 then:
29a6d1215b7cd5 Abel Vesa 2023-06-12 247 properties:
29a6d1215b7cd5 Abel Vesa 2023-06-12 248 reg:
29a6d1215b7cd5 Abel Vesa 2023-06-12 249 maxItems: 1
29a6d1215b7cd5 Abel Vesa 2023-06-12 250 clocks:
29a6d1215b7cd5 Abel Vesa 2023-06-12 251 minItems: 8
29a6d1215b7cd5 Abel Vesa 2023-06-12 252 maxItems: 8
29a6d1215b7cd5 Abel Vesa 2023-06-12 253 else:
29a6d1215b7cd5 Abel Vesa 2023-06-12 254 properties:
29a6d1215b7cd5 Abel Vesa 2023-06-12 255 reg:
9b7c13b83c1ded Abel Vesa 2023-06-23 256 minItems: 1
29a6d1215b7cd5 Abel Vesa 2023-06-12 257 maxItems: 2
29a6d1215b7cd5 Abel Vesa 2023-06-12 258 clocks:
9b7c13b83c1ded Abel Vesa 2023-06-23 259 minItems: 8
29a6d1215b7cd5 Abel Vesa 2023-06-12 260 maxItems: 11
29a6d1215b7cd5 Abel Vesa 2023-06-12 261
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
On 08/09/2023 10:53, Ziqi Chen wrote: > Document the description for the qcom,esi-affinity-mask. This tells me nothing what is this feature for. > > Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com> > --- > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > index bdfa86a..323595f 100644 > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > @@ -97,6 +97,10 @@ properties: > description: > GPIO connected to the RESET pin of the UFS memory device. > > + qcom,esi-affinity-mask: Not tested. You also miss proper type. > + description: > + UFS MCQ ESI affinity mask. Affine ESI on registration according to this CPU mask. And why is this a property of DT? Aren't you now describing driver? Best regards, Krzysztof
Hi Krzysztof， Thanks for your comment very much ~ I will remove this property in next patch version. We just plan to post "msi-parent" property for MCQ. Best Regards, Ziqi On 9/11/2023 2:27 PM, Krzysztof Kozlowski wrote: > On 08/09/2023 10:53, Ziqi Chen wrote: >> Document the description for the qcom,esi-affinity-mask. > > This tells me nothing what is this feature for. > >> >> Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com> >> --- >> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> index bdfa86a..323595f 100644 >> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> @@ -97,6 +97,10 @@ properties: >> description: >> GPIO connected to the RESET pin of the UFS memory device. >> >> + qcom,esi-affinity-mask: > > Not tested. You also miss proper type. > >> + description: >> + UFS MCQ ESI affinity mask. Affine ESI on registration according to this CPU mask. > > And why is this a property of DT? Aren't you now describing driver? > > > > Best regards, > Krzysztof >
Hi, On 08/09/2023 10:53, Ziqi Chen wrote: > Document the description for the qcom,esi-affinity-mask. Do you plan to add all the other MCQ and ESI properties ? (reg, reg-names, msi-parent) Thanks, Neil > > Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com> > --- > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > index bdfa86a..323595f 100644 > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > @@ -97,6 +97,10 @@ properties: > description: > GPIO connected to the RESET pin of the UFS memory device. > > + qcom,esi-affinity-mask: > + description: > + UFS MCQ ESI affinity mask. Affine ESI on registration according to this CPU mask. > + > required: > - compatible > - reg
Hi Neil， Yes，I will post reg-name and msi-parent properties in next version as soon. reg is required property and already exist. but I will make some changes on this property. As for qcom,esi-affinity-mask, we will put it off. Thanks, Ziqi On 9/8/2023 5:35 PM, Neil Armstrong wrote: > Hi, > > On 08/09/2023 10:53, Ziqi Chen wrote: >> Document the description for the qcom,esi-affinity-mask. > > Do you plan to add all the other MCQ and ESI properties ? (reg, > reg-names, msi-parent) > > Thanks, > Neil > >> >> Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com> >> --- >> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> index bdfa86a..323595f 100644 >> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> @@ -97,6 +97,10 @@ properties: >> description: >> GPIO connected to the RESET pin of the UFS memory device. >> + qcom,esi-affinity-mask: >> + description: >> + UFS MCQ ESI affinity mask. Affine ESI on registration >> according to this CPU mask. >> + >> required: >> - compatible >> - reg >
On Fri, 08 Sep 2023 16:53:23 +0800, Ziqi Chen wrote: > Document the description for the qcom,esi-affinity-mask. > > Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com> > --- > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/ufs/qcom,ufs.yaml:102:8: [warning] wrong indentation: expected 6 but found 7 (indentation) dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml: properties:qcom,esi-affinity-mask: 'oneOf' conditional failed, one must be fixed: 'type' is a required property hint: A vendor boolean property can use "type: boolean" /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml: properties:qcom,esi-affinity-mask: 'oneOf' conditional failed, one must be fixed: 'enum' is a required property 'const' is a required property hint: A vendor string property with exact values has an implicit type from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml: properties:qcom,esi-affinity-mask: 'oneOf' conditional failed, one must be fixed: '$ref' is a required property 'allOf' is a required property hint: A vendor property needs a $ref to types.yaml from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml# hint: Vendor specific properties must have a type and description unless they have a defined, common suffix. from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1694163203-39123-1-git-send-email-quic_ziqichen@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
© 2016 - 2025 Red Hat, Inc.