[PATCH] softirq: Adjust comment for CONFIG_PREEMPT_RT in #else

Jesper Dangaard Brouer posted 1 patch 2 years, 4 months ago
kernel/softirq.c |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] softirq: Adjust comment for CONFIG_PREEMPT_RT in #else
Posted by Jesper Dangaard Brouer 2 years, 4 months ago
The #ifdef CONFIG_PREEMPT_RT #else statement had a comment
that made me think the code below #else statement was RT code.
After reading the code closer I realized it was not RT code.
Adjust comment to !RT to helper future readers of the code.

Fixes: 8b1c04acad08 ("softirq: Make softirq control and processing RT aware")
Signed-off-by: Jesper Dangaard Brouer <hawk@kernel.org>
---
 kernel/softirq.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/softirq.c b/kernel/softirq.c
index 807b34ccd797..b9a8384821b9 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -292,7 +292,7 @@ void do_softirq_post_smp_call_flush(unsigned int was_pending)
 		invoke_softirq();
 }
 
-#else /* CONFIG_PREEMPT_RT */
+#else /* !CONFIG_PREEMPT_RT */
 
 /*
  * This one is for softirq.c-internal use, where hardirqs are disabled
Re: [PATCH] softirq: Adjust comment for CONFIG_PREEMPT_RT in #else
Posted by Sebastian Andrzej Siewior 2 years, 4 months ago
On 2023-08-18 10:47:35 [+0200], Jesper Dangaard Brouer wrote:
> The #ifdef CONFIG_PREEMPT_RT #else statement had a comment
> that made me think the code below #else statement was RT code.
> After reading the code closer I realized it was not RT code.
> Adjust comment to !RT to helper future readers of the code.

indeed.

> Fixes: 8b1c04acad08 ("softirq: Make softirq control and processing RT aware")
> Signed-off-by: Jesper Dangaard Brouer <hawk@kernel.org>

Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Sebastian