V3:
 - minor comments fixes and add tags

V2:
- Add new patch2 to fix a memory leak
- rewrite original patch2 to patch3 by refactoring the cleanup path instead of
  introducing a new flag
- Drop original patch3: RDMA/rtrs: Fix use-after-free in rtrs_clt_rdma_cm_handler
  The problem it tried to addressing doesn't appear after the new patch3
  where it adjust the cleanup order

It's trying to fix 1 issue triggered by the following script which
connect/disconnect rnbd frequently.

# cat rnbd-self.sh 
#!/bin/bash

/root/rpma/tools/config_softroce.sh eth0
modprobe rnbd_server
modprobe rnbd_client

while true;
do
        echo "sessname=xyz path=ip:<server-ip> device_path=/dev/nvme0n1" > /sys/devices/virtual/rnbd-client/ctl/map_device
        for i in /sys/block/rnbd*/rnbd/unmap_device
        do
                echo "normal" > $i
        done
done

Li Zhijian (3):
  RDMA/rtrs: remove duplicate cq_num assignment
  RDMA/rtrs: Fix the last iu->buf leak in err path
  RDMA/rtrs: Fix rxe_dealloc_pd warning

 drivers/infiniband/ulp/rtrs/rtrs-clt.c | 56 +++++++++++---------------
 drivers/infiniband/ulp/rtrs/rtrs.c     |  4 +-
 2 files changed, 26 insertions(+), 34 deletions(-)

-- 
2.29.2

On Tue, Apr 25, 2023 at 01:02:40AM +0000, Li Zhijian wrote:
> V3:
>  - minor comments fixes and add tags
> 
> V2:
> - Add new patch2 to fix a memory leak
> - rewrite original patch2 to patch3 by refactoring the cleanup path instead of
>   introducing a new flag
> - Drop original patch3: RDMA/rtrs: Fix use-after-free in rtrs_clt_rdma_cm_handler
>   The problem it tried to addressing doesn't appear after the new patch3
>   where it adjust the cleanup order
> 
> It's trying to fix 1 issue triggered by the following script which
> connect/disconnect rnbd frequently.
> 
> # cat rnbd-self.sh 
> #!/bin/bash
> 
> /root/rpma/tools/config_softroce.sh eth0
> modprobe rnbd_server
> modprobe rnbd_client
> 
> while true;
> do
>         echo "sessname=xyz path=ip:<server-ip> device_path=/dev/nvme0n1" > /sys/devices/virtual/rnbd-client/ctl/map_device
>         for i in /sys/block/rnbd*/rnbd/unmap_device
>         do
>                 echo "normal" > $i
>         done
> done
> 
> Li Zhijian (3):
>   RDMA/rtrs: remove duplicate cq_num assignment

I took this to for-next

>   RDMA/rtrs: Fix the last iu->buf leak in err path
>   RDMA/rtrs: Fix rxe_dealloc_pd warning

And these to for-rc

Thanks,
Jason

ping


On 25/04/2023 09:02, Li Zhijian wrote:
> V3:
>   - minor comments fixes and add tags
> 
> V2:
> - Add new patch2 to fix a memory leak
> - rewrite original patch2 to patch3 by refactoring the cleanup path instead of
>    introducing a new flag
> - Drop original patch3: RDMA/rtrs: Fix use-after-free in rtrs_clt_rdma_cm_handler
>    The problem it tried to addressing doesn't appear after the new patch3
>    where it adjust the cleanup order
> 
> It's trying to fix 1 issue triggered by the following script which
> connect/disconnect rnbd frequently.
> 
> # cat rnbd-self.sh
> #!/bin/bash
> 
> /root/rpma/tools/config_softroce.sh eth0
> modprobe rnbd_server
> modprobe rnbd_client
> 
> while true;
> do
>          echo "sessname=xyz path=ip:<server-ip> device_path=/dev/nvme0n1" > /sys/devices/virtual/rnbd-client/ctl/map_device
>          for i in /sys/block/rnbd*/rnbd/unmap_device
>          do
>                  echo "normal" > $i
>          done
> done
> 
> Li Zhijian (3):
>    RDMA/rtrs: remove duplicate cq_num assignment
>    RDMA/rtrs: Fix the last iu->buf leak in err path
>    RDMA/rtrs: Fix rxe_dealloc_pd warning
> 
>   drivers/infiniband/ulp/rtrs/rtrs-clt.c | 56 +++++++++++---------------
>   drivers/infiniband/ulp/rtrs/rtrs.c     |  4 +-
>   2 files changed, 26 insertions(+), 34 deletions(-)
> 

On Tue, May 09, 2023 at 01:20:09AM +0000, Zhijian Li (Fujitsu) wrote:
> ping

There is no need to ping, -rc1 was opened yesterday only.

Thanks