thermal/drivers/cpuidle_cooling: Delete unmatched comments

[PATCH] thermal/drivers/cpuidle_cooling: Delete unmatched comments

Posted by Chenggang Wang 2 years, 8 months ago

The function no longer returns a value, synchronize the comments.

Signed-off-by: wangchenggang@vivo.com
---
 drivers/thermal/cpuidle_cooling.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/thermal/cpuidle_cooling.c b/drivers/thermal/cpuidle_cooling.c
index 4f41102..7779739 100644
--- a/drivers/thermal/cpuidle_cooling.c
+++ b/drivers/thermal/cpuidle_cooling.c
@@ -236,9 +236,6 @@ static int __cpuidle_cooling_register(struct device_node *np,
  *
  * This function is in charge of creating a cooling device per cpuidle
  * driver and register it to the thermal framework.
- *
- * Return: zero on success, or negative value corresponding to the
- * error detected in the underlying subsystems.
  */
 void cpuidle_cooling_register(struct cpuidle_driver *drv)
 {
-- 
2.7.4

Re: [PATCH] thermal/drivers/cpuidle_cooling: Delete unmatched comments

Posted by Viresh Kumar 2 years, 8 months ago

On 18-04-23, 11:38, Chenggang Wang wrote:
> The function no longer returns a value, synchronize the comments.
> 
> Signed-off-by: wangchenggang@vivo.com
> ---
>  drivers/thermal/cpuidle_cooling.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/thermal/cpuidle_cooling.c b/drivers/thermal/cpuidle_cooling.c
> index 4f41102..7779739 100644
> --- a/drivers/thermal/cpuidle_cooling.c
> +++ b/drivers/thermal/cpuidle_cooling.c
> @@ -236,9 +236,6 @@ static int __cpuidle_cooling_register(struct device_node *np,
>   *
>   * This function is in charge of creating a cooling device per cpuidle
>   * driver and register it to the thermal framework.
> - *
> - * Return: zero on success, or negative value corresponding to the
> - * error detected in the underlying subsystems.
>   */
>  void cpuidle_cooling_register(struct cpuidle_driver *drv)
>  {

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Re: [PATCH] thermal/drivers/cpuidle_cooling: Delete unmatched comments

Posted by Rafael J. Wysocki 2 years, 8 months ago

On Tue, Apr 18, 2023 at 5:53 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 18-04-23, 11:38, Chenggang Wang wrote:
> > The function no longer returns a value, synchronize the comments.
> >
> > Signed-off-by: wangchenggang@vivo.com
> > ---
> >  drivers/thermal/cpuidle_cooling.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/thermal/cpuidle_cooling.c b/drivers/thermal/cpuidle_cooling.c
> > index 4f41102..7779739 100644
> > --- a/drivers/thermal/cpuidle_cooling.c
> > +++ b/drivers/thermal/cpuidle_cooling.c
> > @@ -236,9 +236,6 @@ static int __cpuidle_cooling_register(struct device_node *np,
> >   *
> >   * This function is in charge of creating a cooling device per cpuidle
> >   * driver and register it to the thermal framework.
> > - *
> > - * Return: zero on success, or negative value corresponding to the
> > - * error detected in the underlying subsystems.
> >   */
> >  void cpuidle_cooling_register(struct cpuidle_driver *drv)
> >  {
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Daniel, are you going to pick up this one?

Re: [PATCH] thermal/drivers/cpuidle_cooling: Delete unmatched comments

Posted by Daniel Lezcano 2 years, 8 months ago

On 18/04/2023 15:30, Rafael J. Wysocki wrote:
> On Tue, Apr 18, 2023 at 5:53 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>>
>> On 18-04-23, 11:38, Chenggang Wang wrote:
>>> The function no longer returns a value, synchronize the comments.
>>>
>>> Signed-off-by: wangchenggang@vivo.com
>>> ---
>>>   drivers/thermal/cpuidle_cooling.c | 3 ---
>>>   1 file changed, 3 deletions(-)
>>>
>>> diff --git a/drivers/thermal/cpuidle_cooling.c b/drivers/thermal/cpuidle_cooling.c
>>> index 4f41102..7779739 100644
>>> --- a/drivers/thermal/cpuidle_cooling.c
>>> +++ b/drivers/thermal/cpuidle_cooling.c
>>> @@ -236,9 +236,6 @@ static int __cpuidle_cooling_register(struct device_node *np,
>>>    *
>>>    * This function is in charge of creating a cooling device per cpuidle
>>>    * driver and register it to the thermal framework.
>>> - *
>>> - * Return: zero on success, or negative value corresponding to the
>>> - * error detected in the underlying subsystems.
>>>    */
>>>   void cpuidle_cooling_register(struct cpuidle_driver *drv)
>>>   {
>>
>> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> 
> Daniel, are you going to pick up this one?

Yes

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog