From: Xinlei Lee <xinlei.lee@mediatek.com>
Add the compatible because there are different definitions for cmdq
register bit control in mt8188.
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++
drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++
2 files changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index a13b36ac03a1..9ba05961479d 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -654,6 +654,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = {
.data = (void *)MTK_DSI },
{ .compatible = "mediatek,mt8186-dsi",
.data = (void *)MTK_DSI },
+ { .compatible = "mediatek,mt8188-dsi",
+ .data = (void *)MTK_DSI },
{ }
};
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index 7d5250351193..500a3054282d 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -1208,6 +1208,12 @@ static const struct mtk_dsi_driver_data mt8186_dsi_driver_data = {
.has_size_ctl = true,
};
+static const struct mtk_dsi_driver_data mt8188_dsi_driver_data = {
+ .reg_cmdq_off = 0xd00,
+ .has_shadow_ctl = true,
+ .has_size_ctl = true,
+};
+
static const struct of_device_id mtk_dsi_of_match[] = {
{ .compatible = "mediatek,mt2701-dsi",
.data = &mt2701_dsi_driver_data },
@@ -1217,6 +1223,8 @@ static const struct of_device_id mtk_dsi_of_match[] = {
.data = &mt8183_dsi_driver_data },
{ .compatible = "mediatek,mt8186-dsi",
.data = &mt8186_dsi_driver_data },
+ { .compatible = "mediatek,mt8188-dsi",
+ .data = &mt8188_dsi_driver_data },
{ },
};
MODULE_DEVICE_TABLE(of, mtk_dsi_of_match);
--
2.18.0
Hi, Xinlei: Reorder this patch after patch "[3/3] drm/mediatek: dsi: Add dsi cmdq_ctl to send panel initial code" Regards, Chun-Kuang. <xinlei.lee@mediatek.com> 於 2023年4月13日 週四 下午2:09寫道: > > From: Xinlei Lee <xinlei.lee@mediatek.com> > > Add the compatible because there are different definitions for cmdq > register bit control in mt8188. > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com> > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++ > drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++ > 2 files changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index a13b36ac03a1..9ba05961479d 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -654,6 +654,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { > .data = (void *)MTK_DSI }, > { .compatible = "mediatek,mt8186-dsi", > .data = (void *)MTK_DSI }, > + { .compatible = "mediatek,mt8188-dsi", > + .data = (void *)MTK_DSI }, > { } > }; > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index 7d5250351193..500a3054282d 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -1208,6 +1208,12 @@ static const struct mtk_dsi_driver_data mt8186_dsi_driver_data = { > .has_size_ctl = true, > }; > > +static const struct mtk_dsi_driver_data mt8188_dsi_driver_data = { > + .reg_cmdq_off = 0xd00, > + .has_shadow_ctl = true, > + .has_size_ctl = true, > +}; > + > static const struct of_device_id mtk_dsi_of_match[] = { > { .compatible = "mediatek,mt2701-dsi", > .data = &mt2701_dsi_driver_data }, > @@ -1217,6 +1223,8 @@ static const struct of_device_id mtk_dsi_of_match[] = { > .data = &mt8183_dsi_driver_data }, > { .compatible = "mediatek,mt8186-dsi", > .data = &mt8186_dsi_driver_data }, > + { .compatible = "mediatek,mt8188-dsi", > + .data = &mt8188_dsi_driver_data }, > { }, > }; > MODULE_DEVICE_TABLE(of, mtk_dsi_of_match); > -- > 2.18.0 >
On 13/04/2023 08:09, xinlei.lee@mediatek.com wrote: > From: Xinlei Lee <xinlei.lee@mediatek.com> > > Add the compatible because there are different definitions for cmdq > register bit control in mt8188. > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com> > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++ > drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++ > 2 files changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index a13b36ac03a1..9ba05961479d 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -654,6 +654,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { > .data = (void *)MTK_DSI }, > { .compatible = "mediatek,mt8186-dsi", > .data = (void *)MTK_DSI }, > + { .compatible = "mediatek,mt8188-dsi", > + .data = (void *)MTK_DSI }, > { } > }; > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index 7d5250351193..500a3054282d 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -1208,6 +1208,12 @@ static const struct mtk_dsi_driver_data mt8186_dsi_driver_data = { > .has_size_ctl = true, > }; > > +static const struct mtk_dsi_driver_data mt8188_dsi_driver_data = { > + .reg_cmdq_off = 0xd00, > + .has_shadow_ctl = true, > + .has_size_ctl = true, > +}; > + > static const struct of_device_id mtk_dsi_of_match[] = { > { .compatible = "mediatek,mt2701-dsi", > .data = &mt2701_dsi_driver_data }, > @@ -1217,6 +1223,8 @@ static const struct of_device_id mtk_dsi_of_match[] = { > .data = &mt8183_dsi_driver_data }, > { .compatible = "mediatek,mt8186-dsi", > .data = &mt8186_dsi_driver_data }, > + { .compatible = "mediatek,mt8188-dsi", > + .data = &mt8188_dsi_driver_data }, > { }, > }; > MODULE_DEVICE_TABLE(of, mtk_dsi_of_match);
© 2016 - 2024 Red Hat, Inc.