[v2] USB: FHCI: fix error return code in of_fhci_probe()

[PATCH v2] USB: FHCI: fix error return code in of_fhci_probe()

Posted by Wang Yufen 2 years, 9 months ago

Fix to return a negative error code of PTR_ERR(fhci->gpiods[i])
instead of 0.

Fixes: a4efdb8a423b ("USB: FHCI: Switch to GPIO descriptors")
Signed-off-by: Wang Yufen <wangyufen@huawei.com>
---
 drivers/usb/host/fhci-hcd.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c
index 95a4446..ca4b311 100644
--- a/drivers/usb/host/fhci-hcd.c
+++ b/drivers/usb/host/fhci-hcd.c
@@ -639,8 +639,9 @@ static int of_fhci_probe(struct platform_device *ofdev)
 					NULL, i, GPIOD_OUT_LOW);
 
 		if (IS_ERR(fhci->gpiods[i])) {
-			dev_err(dev, "incorrect GPIO%d: %ld\n",
-				i, PTR_ERR(fhci->gpiods[i]));
+			ret = PTR_ERR(fhci->gpiods[i])
+			dev_err(dev, "incorrect GPIO%d: %d\n",
+				i, ret);
 			goto err_gpios;
 		}
 		if (!fhci->gpiods[i]) {
-- 
1.8.3.1

Re: [PATCH v2] USB: FHCI: fix error return code in of_fhci_probe()

Posted by Linus Walleij 2 years, 9 months ago

On Tue, Nov 29, 2022 at 7:21 AM Wang Yufen <wangyufen@huawei.com> wrote:

> Fix to return a negative error code of PTR_ERR(fhci->gpiods[i])
> instead of 0.
>
> Fixes: a4efdb8a423b ("USB: FHCI: Switch to GPIO descriptors")
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Re: [PATCH v2] USB: FHCI: fix error return code in of_fhci_probe()

Posted by wangyufen 2 years, 9 months ago

Please ignore.

Thanks.

在 2022/11/29 14:41, Wang Yufen 写道:
> Fix to return a negative error code of PTR_ERR(fhci->gpiods[i])
> instead of 0.
> 
> Fixes: a4efdb8a423b ("USB: FHCI: Switch to GPIO descriptors")
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
> ---
>   drivers/usb/host/fhci-hcd.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c
> index 95a4446..ca4b311 100644
> --- a/drivers/usb/host/fhci-hcd.c
> +++ b/drivers/usb/host/fhci-hcd.c
> @@ -639,8 +639,9 @@ static int of_fhci_probe(struct platform_device *ofdev)
>   					NULL, i, GPIOD_OUT_LOW);
>   
>   		if (IS_ERR(fhci->gpiods[i])) {
> -			dev_err(dev, "incorrect GPIO%d: %ld\n",
> -				i, PTR_ERR(fhci->gpiods[i]));
> +			ret = PTR_ERR(fhci->gpiods[i])
> +			dev_err(dev, "incorrect GPIO%d: %d\n",
> +				i, ret);
>   			goto err_gpios;
>   		}
>   		if (!fhci->gpiods[i]) {