[PATCH] net: wwan: t7xx: Fix the ACPI memory leak

Hanjun Guo posted 1 patch 3 years, 4 months ago
drivers/net/wwan/t7xx/t7xx_modem_ops.c | 2 ++
1 file changed, 2 insertions(+)
[PATCH] net: wwan: t7xx: Fix the ACPI memory leak
Posted by Hanjun Guo 3 years, 4 months ago
The ACPI buffer memory (buffer.pointer) should be freed as the
buffer is not used after acpi_evaluate_object(), free it to
prevent memory leak.

Fixes: 13e920d93e37 ("net: wwan: t7xx: Add core components")
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
 drivers/net/wwan/t7xx/t7xx_modem_ops.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/wwan/t7xx/t7xx_modem_ops.c b/drivers/net/wwan/t7xx/t7xx_modem_ops.c
index 3458af3..7d0f5e4 100644
--- a/drivers/net/wwan/t7xx/t7xx_modem_ops.c
+++ b/drivers/net/wwan/t7xx/t7xx_modem_ops.c
@@ -165,6 +165,8 @@ static int t7xx_acpi_reset(struct t7xx_pci_dev *t7xx_dev, char *fn_name)
 		return -EFAULT;
 	}
 
+	kfree(buffer.pointer);
+
 #endif
 	return 0;
 }
-- 
1.7.12.4
Re: [PATCH] net: wwan: t7xx: Fix the ACPI memory leak
Posted by patchwork-bot+netdevbpf@kernel.org 3 years, 4 months ago
Hello:

This patch was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@redhat.com>:

On Tue, 22 Nov 2022 20:19:40 +0800 you wrote:
> The ACPI buffer memory (buffer.pointer) should be freed as the
> buffer is not used after acpi_evaluate_object(), free it to
> prevent memory leak.
> 
> Fixes: 13e920d93e37 ("net: wwan: t7xx: Add core components")
> Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
> 
> [...]

Here is the summary with links:
  - net: wwan: t7xx: Fix the ACPI memory leak
    https://git.kernel.org/netdev/net/c/08e8a949f684

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html