[PATCH v2 3/4] ufs: core: Remove len parameter from ufshcd_set_active_icc_lvl

Arthur Simchaev posted 4 patches 3 years, 5 months ago
There is a newer version of this series
[PATCH v2 3/4] ufs: core: Remove len parameter from ufshcd_set_active_icc_lvl
Posted by Arthur Simchaev 3 years, 5 months ago
len argument is not used anymore in ufshcd_set_active_icc_lvl function.

Signed-off-by: Arthur Simchaev <Arthur.Simchaev@wdc.com>
---
 drivers/ufs/core/ufshcd.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index aa46292..9cc3abd 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -7386,7 +7386,7 @@ static u32 ufshcd_get_max_icc_level(int sup_curr_uA, u32 start_scan,
  * Returns calculated ICC level
  */
 static u32 ufshcd_find_max_sup_active_icc_level(struct ufs_hba *hba,
-						const u8 *desc_buf, int len)
+						const u8 *desc_buf)
 {
 	u32 icc_level = 0;
 
@@ -7444,8 +7444,7 @@ static void ufshcd_set_active_icc_lvl(struct ufs_hba *hba)
 		goto out;
 	}
 
-	icc_level = ufshcd_find_max_sup_active_icc_level(hba, desc_buf,
-							 QUERY_DESC_MAX_SIZE);
+	icc_level = ufshcd_find_max_sup_active_icc_level(hba, desc_buf);
 	dev_dbg(hba->dev, "%s: setting icc_level 0x%x", __func__, icc_level);
 
 	ret = ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_WRITE_ATTR,
-- 
2.7.4
Re: [PATCH v2 3/4] ufs: core: Remove len parameter from ufshcd_set_active_icc_lvl
Posted by Bean Huo 3 years, 4 months ago
Arthur,

On 02.11.22 3:29 PM, Arthur Simchaev wrote:
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index aa46292..9cc3abd 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -7386,7 +7386,7 @@ static u32 ufshcd_get_max_icc_level(int sup_curr_uA, u32 start_scan,
>    * Returns calculated ICC level
>    */
>   static u32 ufshcd_find_max_sup_active_icc_level(struct ufs_hba *hba,
> -						const u8 *desc_buf, int len)
> +						const u8 *desc_buf)


'len' description of 'ufshcd_find_max_sup_active_icc_level()' should be 
removed as well.

Kind regards,

Bean
RE: [PATCH v2 3/4] ufs: core: Remove len parameter from ufshcd_set_active_icc_lvl
Posted by Arthur Simchaev 3 years, 4 months ago
> 
> 
> 'len' description of 'ufshcd_find_max_sup_active_icc_level()' should be
> removed as well.
> 
> Kind regards,
> 
> Bean
Done.

Regards
Arthur