can: j1939: j1939_session_tx_eoma(): fix debug info

[PATCH net-next] can: j1939: j1939_session_tx_eoma(): fix debug info

Posted by Zhang Changzhong 3 years, 6 months ago

Use "%s" instead of "%p" to print function name in debug info.

Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
---
 net/can/j1939/transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/can/j1939/transport.c b/net/can/j1939/transport.c
index d7d86c9..6ec48a4 100644
--- a/net/can/j1939/transport.c
+++ b/net/can/j1939/transport.c
@@ -985,7 +985,7 @@ static int j1939_session_tx_eoma(struct j1939_session *session)
 	/* wait for the EOMA packet to come in */
 	j1939_tp_set_rxtimeout(session, 1250);
 
-	netdev_dbg(session->priv->ndev, "%p: 0x%p\n", __func__, session);
+	netdev_dbg(session->priv->ndev, "%s: 0x%p\n", __func__, session);
 
 	return 0;
 }
-- 
2.9.5

Re: [PATCH net-next] can: j1939: j1939_session_tx_eoma(): fix debug info

Posted by Marc Kleine-Budde 3 years, 6 months ago

On 30.09.2022 14:52:08, Zhang Changzhong wrote:
> Use "%s" instead of "%p" to print function name in debug info.
> 
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>

Applied to linux-can-next.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Re: [PATCH net-next] can: j1939: j1939_session_tx_eoma(): fix debug info

Posted by Oleksij Rempel 3 years, 6 months ago

On Fri, Sep 30, 2022 at 02:52:08PM +0800, Zhang Changzhong wrote:
> Use "%s" instead of "%p" to print function name in debug info.
> 
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>

Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>

Thank you!

> ---
>  net/can/j1939/transport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/can/j1939/transport.c b/net/can/j1939/transport.c
> index d7d86c9..6ec48a4 100644
> --- a/net/can/j1939/transport.c
> +++ b/net/can/j1939/transport.c
> @@ -985,7 +985,7 @@ static int j1939_session_tx_eoma(struct j1939_session *session)
>  	/* wait for the EOMA packet to come in */
>  	j1939_tp_set_rxtimeout(session, 1250);
>  
> -	netdev_dbg(session->priv->ndev, "%p: 0x%p\n", __func__, session);
> +	netdev_dbg(session->priv->ndev, "%s: 0x%p\n", __func__, session);
>  
>  	return 0;
>  }
> -- 
> 2.9.5
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |