When synthesizing event with SPE data source, commit 4e6430cbb1a9("perf
arm-spe: Use SPE data source for neoverse cores") augment the type with
source information by MIDR. However, is_midr_in_range only compares the
first entry in neoverse_spe.

Change is_midr_in_range to is_midr_in_range_list to traverse the
neoverse_spe array so that all neoverse cores synthesize event with data
source packet.

Fixes: 4e6430cbb1a9("perf arm-spe: Use SPE data source for neoverse cores")
Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
---
 tools/perf/util/arm-spe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c
index 22dcfe0..906476a 100644
--- a/tools/perf/util/arm-spe.c
+++ b/tools/perf/util/arm-spe.c
@@ -498,7 +498,7 @@ static void arm_spe__synth_data_source_generic(const struct arm_spe_record *reco
 static u64 arm_spe__synth_data_source(const struct arm_spe_record *record, u64 midr)
 {
 	union perf_mem_data_src	data_src = { 0 };
-	bool is_neoverse = is_midr_in_range(midr, neoverse_spe);
+	bool is_neoverse = is_midr_in_range_list(midr, neoverse_spe);
 
 	if (record->op == ARM_SPE_LD)
 		data_src.mem_op = PERF_MEM_OP_LOAD;
-- 
1.8.3.1

> When synthesizing event with SPE data source, commit 4e6430cbb1a9("perf
> arm-spe: Use SPE data source for neoverse cores") augment the type with
> source information by MIDR. However, is_midr_in_range only compares the
> first entry in neoverse_spe.
> 
> Change is_midr_in_range to is_midr_in_range_list to traverse the
> neoverse_spe array so that all neoverse cores synthesize event with data
> source packet.
> 
> Fixes: 4e6430cbb1a9("perf arm-spe: Use SPE data source for neoverse cores")
> Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>

Thanks for catching this, you're absolutely right.

Reviewed-by: Ali Saidi <alisaidi@amazon.com>

Ali

On Mon, Sep 26, 2022 at 02:10:32PM +0000, Ali Saidi wrote:
> > When synthesizing event with SPE data source, commit 4e6430cbb1a9("perf
> > arm-spe: Use SPE data source for neoverse cores") augment the type with
> > source information by MIDR. However, is_midr_in_range only compares the
> > first entry in neoverse_spe.
> > 
> > Change is_midr_in_range to is_midr_in_range_list to traverse the
> > neoverse_spe array so that all neoverse cores synthesize event with data
> > source packet.
> > 
> > Fixes: 4e6430cbb1a9("perf arm-spe: Use SPE data source for neoverse cores")
> > Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
> 
> Thanks for catching this, you're absolutely right.
> 
> Reviewed-by: Ali Saidi <alisaidi@amazon.com>

It's also good for me:
Reviewed-by: Leo Yan <leo.yan@linaro.org>

Em Mon, Sep 26, 2022 at 11:00:31PM +0800, Leo Yan escreveu:
> On Mon, Sep 26, 2022 at 02:10:32PM +0000, Ali Saidi wrote:
> > > When synthesizing event with SPE data source, commit 4e6430cbb1a9("perf
> > > arm-spe: Use SPE data source for neoverse cores") augment the type with
> > > source information by MIDR. However, is_midr_in_range only compares the
> > > first entry in neoverse_spe.
> > > 
> > > Change is_midr_in_range to is_midr_in_range_list to traverse the
> > > neoverse_spe array so that all neoverse cores synthesize event with data
> > > source packet.
> > > 
> > > Fixes: 4e6430cbb1a9("perf arm-spe: Use SPE data source for neoverse cores")
> > > Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
> > 
> > Thanks for catching this, you're absolutely right.
> > 
> > Reviewed-by: Ali Saidi <alisaidi@amazon.com>
> 
> It's also good for me:
> Reviewed-by: Leo Yan <leo.yan@linaro.org>

Thanks, applied.

- Arnaldo