[v1] scsi: ufs: Remove redundant function definitions from ufshcd.h

[PATCH] scsi: ufs: Remove redundant function definitions from ufshcd.h

Posted by Arthur Simchaev 3 years, 2 months ago

This patch removes Query-Request API functions declaration from
from include/ufs/ufshcd.h. Those declarations belongs solely to
ufs core privet header.

Signed-off-by: Arthur Simchaev <Arthur.Simchaev@wdc.com>
---
 drivers/ufs/core/ufshcd-priv.h |  5 +++++
 include/ufs/ufshcd.h           | 19 +------------------
 2 files changed, 6 insertions(+), 18 deletions(-)

diff --git a/drivers/ufs/core/ufshcd-priv.h b/drivers/ufs/core/ufshcd-priv.h
index d00dba1..f68ca33 100644
--- a/drivers/ufs/core/ufshcd-priv.h
+++ b/drivers/ufs/core/ufshcd-priv.h
@@ -42,6 +42,11 @@ static inline void ufs_hwmon_remove(struct ufs_hba *hba) {}
 static inline void ufs_hwmon_notify_event(struct ufs_hba *hba, u8 ee_mask) {}
 #endif
 
+int ufshcd_query_descriptor_retry(struct ufs_hba *hba,
+				  enum query_opcode opcode,
+				  enum desc_idn idn, u8 index,
+				  u8 selector,
+				  u8 *desc_buf, int *buf_len);
 int ufshcd_read_desc_param(struct ufs_hba *hba,
 			   enum desc_idn desc_id,
 			   int desc_index,
diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h
index 24c97e0..3647a71 100644
--- a/include/ufs/ufshcd.h
+++ b/include/ufs/ufshcd.h
@@ -1176,24 +1176,7 @@ static inline int ufshcd_disable_host_tx_lcc(struct ufs_hba *hba)
 }
 
 /* Expose Query-Request API */
-int ufshcd_query_descriptor_retry(struct ufs_hba *hba,
-				  enum query_opcode opcode,
-				  enum desc_idn idn, u8 index,
-				  u8 selector,
-				  u8 *desc_buf, int *buf_len);
-int ufshcd_read_desc_param(struct ufs_hba *hba,
-			   enum desc_idn desc_id,
-			   int desc_index,
-			   u8 param_offset,
-			   u8 *param_read_buf,
-			   u8 param_size);
-int ufshcd_query_attr_retry(struct ufs_hba *hba, enum query_opcode opcode,
-			    enum attr_idn idn, u8 index, u8 selector,
-			    u32 *attr_val);
-int ufshcd_query_attr(struct ufs_hba *hba, enum query_opcode opcode,
-		      enum attr_idn idn, u8 index, u8 selector, u32 *attr_val);
-int ufshcd_query_flag(struct ufs_hba *hba, enum query_opcode opcode,
-	enum flag_idn idn, u8 index, bool *flag_res);
+
 
 void ufshcd_auto_hibern8_enable(struct ufs_hba *hba);
 void ufshcd_auto_hibern8_update(struct ufs_hba *hba, u32 ahit);
-- 
2.7.4

Re: [PATCH] scsi: ufs: Remove redundant function definitions from ufshcd.h

Posted by Bart Van Assche 3 years, 2 months ago

On 9/19/22 01:21, Arthur Simchaev wrote:
> This patch removes Query-Request API functions declaration from
> from include/ufs/ufshcd.h. Those declarations belongs solely to
> ufs core privet header.
            ^^^^^^
            private?

RE: [PATCH] scsi: ufs: Remove redundant function definitions from ufshcd.h

Posted by Arthur Simchaev 3 years, 2 months ago

Done

Regards
Arthur

> -----Original Message-----
> From: Bart Van Assche <bvanassche@acm.org>
> Sent: Tuesday, September 20, 2022 8:19 PM
> To: Arthur Simchaev <Arthur.Simchaev@wdc.com>;
> martin.petersen@oracle.com
> Cc: Avri Altman <Avri.Altman@wdc.com>; Avi Shchislowski
> <Avi.Shchislowski@wdc.com>; beanhuo@micron.com; linux-
> scsi@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] scsi: ufs: Remove redundant function definitions from
> ufshcd.h
> 
> CAUTION: This email originated from outside of Western Digital. Do not click
> on links or open attachments unless you recognize the sender and know that
> the content is safe.
> 
> 
> On 9/19/22 01:21, Arthur Simchaev wrote:
> > This patch removes Query-Request API functions declaration from
> > from include/ufs/ufshcd.h. Those declarations belongs solely to
> > ufs core privet header.
>             ^^^^^^
>             private?

Re: [PATCH] scsi: ufs: Remove redundant function definitions from ufshcd.h

Posted by Bean Huo 3 years, 2 months ago

Hi, Arthur,


On Mon, 2022-09-19 at 11:21 +0300, Arthur Simchaev wrote:
> This patch removes Query-Request API functions declaration from
> from include/ufs/ufshcd.h. Those declarations belongs solely to
   ^ unnecessary "from"                             ^belong

> ufs core privet header.
> 
> Signed-off-by: Arthur Simchaev <Arthur.Simchaev@wdc.com>
> ---
>  drivers/ufs/core/ufshcd-priv.h |  5 +++++
>  include/ufs/ufshcd.h           | 19 +------------------
>  2 files changed, 6 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/ufs/core/ufshcd-priv.h
> b/drivers/ufs/core/ufshcd-priv.h
> index d00dba1..f68ca33 100644
> --- a/drivers/ufs/core/ufshcd-priv.h
> +++ b/drivers/ufs/core/ufshcd-priv.h
> @@ -42,6 +42,11 @@ static inline void ufs_hwmon_remove(struct ufs_hba
> *hba) {}
>  static inline void ufs_hwmon_notify_event(struct ufs_hba *hba, u8
> ee_mask) {}
>  #endif
>  
> +int ufshcd_query_descriptor_retry(struct ufs_hba *hba,
> +                                 enum query_opcode opcode,
> +                                 enum desc_idn idn, u8 index,
> +                                 u8 selector,
> +                                 u8 *desc_buf, int *buf_len);
>  int ufshcd_read_desc_param(struct ufs_hba *hba,
>                            enum desc_idn desc_id,
>                            int desc_index,
> diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h
> index 24c97e0..3647a71 100644
> --- a/include/ufs/ufshcd.h
> +++ b/include/ufs/ufshcd.h
> @@ -1176,24 +1176,7 @@ static inline int
> ufshcd_disable_host_tx_lcc(struct ufs_hba *hba)
>  }
>  
>  /* Expose Query-Request API */
This comment should be removed, too?



Reviewed-by: Bean Huo <beanhuo@micron.com>


Kind regards,
Bean