mm/damon/sysfs: use the wrapper directly to check if the kdamond is running

[PATCH] mm/damon/sysfs: use the wrapper directly to check if the kdamond is running

Posted by xiakaixu1987@gmail.com 3 years, 6 months ago

From: Kaixu Xia <kaixuxia@tencent.com>

We can use the 'damon_sysfs_kdamond_running()' wrapper directly to
check if the kdamond is running in 'damon_sysfs_turn_damon_on()'.

Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
 mm/damon/sysfs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
index 7488e27c87c3..84861c4085a5 100644
--- a/mm/damon/sysfs.c
+++ b/mm/damon/sysfs.c
@@ -2455,8 +2455,7 @@ static int damon_sysfs_turn_damon_on(struct damon_sysfs_kdamond *kdamond)
 	struct damon_ctx *ctx;
 	int err;
 
-	if (kdamond->damon_ctx &&
-			damon_sysfs_ctx_running(kdamond->damon_ctx))
+	if (damon_sysfs_kdamond_running(kdamond))
 		return -EBUSY;
 	if (damon_sysfs_cmd_request.kdamond == kdamond)
 		return -EBUSY;
-- 
2.27.0

Re: [PATCH] mm/damon/sysfs: use the wrapper directly to check if the kdamond is running

Posted by SeongJae Park 3 years, 6 months ago

Hi Kaixu,

On Mon, 12 Sep 2022 23:11:53 +0800 xiakaixu1987@gmail.com wrote:

> From: Kaixu Xia <kaixuxia@tencent.com>
> 
> We can use the 'damon_sysfs_kdamond_running()' wrapper directly to
> check if the kdamond is running in 'damon_sysfs_turn_damon_on()'.
> 
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

> ---
>  mm/damon/sysfs.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
> index 7488e27c87c3..84861c4085a5 100644
> --- a/mm/damon/sysfs.c
> +++ b/mm/damon/sysfs.c
> @@ -2455,8 +2455,7 @@ static int damon_sysfs_turn_damon_on(struct damon_sysfs_kdamond *kdamond)
>  	struct damon_ctx *ctx;
>  	int err;
>  
> -	if (kdamond->damon_ctx &&
> -			damon_sysfs_ctx_running(kdamond->damon_ctx))
> +	if (damon_sysfs_kdamond_running(kdamond))
>  		return -EBUSY;
>  	if (damon_sysfs_cmd_request.kdamond == kdamond)
>  		return -EBUSY;
> -- 
> 2.27.0
>

Re: [PATCH] mm/damon/sysfs: use the wrapper directly to check if the kdamond is running

Posted by Muchun Song 3 years, 6 months ago


> On Sep 12, 2022, at 23:11, xiakaixu1987@gmail.com wrote:
> 
> From: Kaixu Xia <kaixuxia@tencent.com>
> 
> We can use the 'damon_sysfs_kdamond_running()' wrapper directly to
> check if the kdamond is running in 'damon_sysfs_turn_damon_on()'.
> 
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>

Reviewed-by: Muchun Song <songmuchun@bytedance.com>

Thanks.